From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752111AbcFNKCl (ORCPT ); Tue, 14 Jun 2016 06:02:41 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:56808 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751371AbcFNKCj (ORCPT ); Tue, 14 Jun 2016 06:02:39 -0400 From: Arnd Bergmann To: Florian Fainelli Cc: Arnd Bergmann , "David S. Miller" , Andrew Lunn , Pramod Kumar , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mdio: mux: avoid 'maybe-uninitialized' warning Date: Tue, 14 Jun 2016 12:03:17 +0200 Message-Id: <1465898632-2248093-1-git-send-email-arnd@arndb.de> X-Mailer: git-send-email 2.7.0 X-Provags-ID: V03:K0:gGKXpppCIlfnrRFGV8twc57Q1W2P38SsumEhiDHYrqiNnI3vTUX JfNlrjZMzzpfoznBNgeiRpVBVEKec5HeQDaWXch6Dzs94uDRkA/v1M45iDsGCukfdM1/bUq BSf2HG2DmocZi5HIIU2knBt715odu20XDxaPZV7QkI24cy7hbST5rvVtpiF8JB8bB4Y9xVQ OukRj1lTxBXvgqoW898yQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:1RYHtSgk54U=:Le033gLL+Dugg2/1RjGo1o gDhs0IeVsvbRQX4a7ycccbscB2Yp4Bp3FKPi9CaNWKz/5I1FWGs1umOqUzktY/gZ+ueTmHqwL gNWyAbCtSro5YVqEe8d8RlNoGPXimPpByqAYet1kivw6q1wK4yptvSZNSmCY9qr3zq4NJ9U22 cJ+ZVmuqU3wFJNEz9kunxeZPEVJd5hPUmV4BYSOXAVqDh9ZJ0v/BM+QXjDttv/VQiQ8B+esAj p7b7KDBLBAN4AoqgHN2HlDplY+xcefhMmRcInRWyiW20MoUbOs75g/VWhi3xYUcQoefTTlSvM t74/GsnpoLYNqIN2cDsDiCIHT29xI8s2Dug60XK+7DMvuUhItxpsMGPrrfXZ4mmHruzgPE4sy J8kSISlHTPykN7JjUcxJuBSAGdfztoND4i8Jgrt5RXPxMOUe9L4pvEq0vIM//BfTA67bFkO2G GWuPWxFsOE9bj0fKX8arZfWD5HDebCUrwocIKIjb0nBWlo+ImBNQ979y8O/ZxD3JHlf7xvQ8s u2OwUiUpJm5HEpUIy78j3+IyWUAfVb/zxzg8UUnBMexyQhflmosnHcrwbrDjsLIq/y99Sn0/a t1rR/8eQcOEDKgoWUqpwc8vI0DwoMwnQdNvuiR1Lo5ptuxOL88U+xOsR+WH4GF4BTN0V96DpN z2TnZT2EXku2kOWSgW5mM/f+iRxFUN/QayyG1mCoFwQhTm8mwcLW9hRYSauMquwc1PJ0= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The latest changes to the MDIO code introduced a false-positive warning with gcc-6 (possibly others): drivers/net/phy/mdio-mux.c: In function 'mdio_mux_init': drivers/net/phy/mdio-mux.c:188:3: error: 'parent_bus_node' may be used uninitialized in this function [-Werror=maybe-uninitialized] It's easy to avoid the warning by making sure the parent_bus_node is initialized in both cases at the start of the function, since the later 'of_node_put()' call is also valid for a NULL pointer argument. Signed-off-by: Arnd Bergmann Fixes: f20e6657a875 ("mdio: mux: Enhanced MDIO mux framework for integrated multiplexers") --- drivers/net/phy/mdio-mux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/phy/mdio-mux.c b/drivers/net/phy/mdio-mux.c index dbd4ecc205dc..963838d4fac1 100644 --- a/drivers/net/phy/mdio-mux.c +++ b/drivers/net/phy/mdio-mux.c @@ -115,6 +115,7 @@ int mdio_mux_init(struct device *dev, goto err_parent_bus; } } else { + parent_bus_node = NULL; parent_bus = mux_bus; } @@ -184,8 +185,7 @@ int mdio_mux_init(struct device *dev, put_device(&pb->mii_bus->dev); err_parent_bus: - if (!mux_bus) - of_node_put(parent_bus_node); + of_node_put(parent_bus_node); return ret_val; } EXPORT_SYMBOL_GPL(mdio_mux_init); -- 2.7.0