From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932697AbcFOVnD (ORCPT ); Wed, 15 Jun 2016 17:43:03 -0400 Received: from host-92-27-6-192.static.as13285.net ([92.27.6.192]:50890 "EHLO nabal.armitage.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbcFOVnA (ORCPT ); Wed, 15 Jun 2016 17:43:00 -0400 From: Quentin Armitage To: Wensong Zhang , Simon Horman , Julian Anastasov , Pablo Neira Ayuso , Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Cc: Quentin Armitage Subject: [PATCH v3 0/4] ipvs: fix backup sync daemon with IPv6, and minor updates Date: Wed, 15 Jun 2016 22:42:40 +0100 Message-Id: <1466026964-14114-1-git-send-email-quentin@armitage.org.uk> X-Mailer: git-send-email 1.7.7.6 In-Reply-To: <1465914262-30112-1-git-send-email-quentin@armitage.org.uk> References: <1465914262-30112-1-git-send-email-quentin@armitage.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series of patches arise from discovering that: ipvsadm --start-daemon backup --mcast-group IPv6_address ... would always fail. The first patch resolves the problem. The second and third patches are optimizations that were noticed while investigating the original problem. The fourth patch adds a lock which appears to have been omitted, and the final patch adds the recently added sync daemon multicast parameters to the log messages that are written when the sync daemons start. v2 fixes a compile error in a debug message identified by kbuild test robot. Now compiles with CONFIG_IP_VS_DEBUG enabled. Patch 2/5 is modified to correct the problem, and patch 3/5 is modifed to apply with the modified patch 2/5. v3 incorporates changes suggested by Julian Anastasov. Patch 1 now sets 'sock->sk->sk_bound_dev_if = ifindex' rather than setting sin6_scope_id. Also remove the locks since unnecessary. Patch 3 shortens the logged message in order not to exceed 80-char limit. Patch 4 Removed, the locks aren't necessary Patch 5 No longer changes indentation of existing pr_info. Also removes <> around commit IDs in commit description. Patches 1, 2, 3, 5 are updated to resolve coding style warnings, and all pass with 0 errors, warnings and checks. Patch 5 now becomes patch 4. The changes have all been tested and work as expected. Quentin Armitage (4): ipvs: Enable setting IPv6 multicast address for ipvs ipvs: Stop calling __dev_get_by_name() repeatedly when starting sync daemon ipvs: Don't check result < 0 after setting result = 0 ipvs: log additional sync daemon parameters net/netfilter/ipvs/ip_vs_sync.c | 105 +++++++++++++++++++-------------------- 1 files changed, 52 insertions(+), 53 deletions(-) -- 1.7.7.6