From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753902AbcFPJDf (ORCPT ); Thu, 16 Jun 2016 05:03:35 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:51522 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbcFPJDb (ORCPT ); Thu, 16 Jun 2016 05:03:31 -0400 Message-ID: <1466067807.3343.12.camel@pengutronix.de> Subject: Re: [STLinux Kernel] [PATCH 0/7] reset: Consumers to explicitly request 'exclusive' or 'shared' lines From: Philipp Zabel To: Lee Jones Cc: Peter Griffin , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, balbi@kernel.org, kernel@stlinux.com, srinivas.kandagatla@gmail.com, linux-usb@vger.kernel.org, kishon@ti.com, gregkh@linuxfoundation.org Date: Thu, 16 Jun 2016 11:03:27 +0200 In-Reply-To: <20160607092456.GE18047@dell> References: <20160606155655.10860-1-lee.jones@linaro.org> <20160607084208.GB22960@griffinp-ThinkPad-X1-Carbon-2nd> <20160607091543.GC18047@dell> <20160607092456.GE18047@dell> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lee, Am Dienstag, den 07.06.2016, 10:24 +0100 schrieb Lee Jones: [...] > I guess it should really go into the -rcs, yes. Since Hans' patch > actually breaks a lot of devices. I'm pretty surprised a patch > capable of this much damage was actually accepted to be honest. I wasn't aware there were more drivers already sharing resets, and arguably before Hans' patches this wasn't really supported at all. It only worked by circumstance. > A better approach would have been to issue a warning, but keep the > semantics the same for at least a couple of releases. However, I > guess the damage has been done now, so let's do what we can do fix > it. Agreed. regards Philipp