From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753963AbcFPJDx (ORCPT ); Thu, 16 Jun 2016 05:03:53 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:59608 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751683AbcFPJDd (ORCPT ); Thu, 16 Jun 2016 05:03:33 -0400 Message-ID: <1466067810.3343.13.camel@pengutronix.de> Subject: Re: [PATCH 7/7] usb: dwc3: st: Inform the reset framework that our reset line may be shared From: Philipp Zabel To: Lee Jones Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, maxime.coquelin@st.com, srinivas.kandagatla@gmail.com, kishon@ti.com, balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Date: Thu, 16 Jun 2016 11:03:30 +0200 In-Reply-To: <20160606155655.10860-8-lee.jones@linaro.org> References: <20160606155655.10860-1-lee.jones@linaro.org> <20160606155655.10860-8-lee.jones@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Montag, den 06.06.2016, 16:56 +0100 schrieb Lee Jones: > On the STiH410 B2120 development board the MiPHY28lp shares its reset > line with the Synopsys DWC3 SuperSpeed (SS) USB 3.0 Dual-Role-Device > (DRD). New functionality in the reset subsystems forces consumers to > be explicit when requesting shared/exclusive reset lines. > > Signed-off-by: Lee Jones > --- > drivers/usb/dwc3/dwc3-st.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c > index 5c0adb9..e77bacb 100644 > --- a/drivers/usb/dwc3/dwc3-st.c > +++ b/drivers/usb/dwc3/dwc3-st.c > @@ -227,7 +227,8 @@ static int st_dwc3_probe(struct platform_device *pdev) > dev_vdbg(&pdev->dev, "glue-logic addr 0x%p, syscfg-reg offset 0x%x\n", > dwc3_data->glue_base, dwc3_data->syscfg_reg_off); > > - dwc3_data->rstc_pwrdn = devm_reset_control_get(dev, "powerdown"); > + dwc3_data->rstc_pwrdn = > + devm_reset_control_get_exclusive(dev, "powerdown"); This hunk is not critical. If you split it into a separate patch, this one doesn't depend on patch 2. The same applies to patch 8. That way I could take patches 1-5 through reset/next and you wouldn't have to wait for them to be merged into arm-soc. regards Philipp