From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752635AbcFTGIJ (ORCPT ); Mon, 20 Jun 2016 02:08:09 -0400 Received: from smtprelay0122.hostedemail.com ([216.40.44.122]:53637 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752556AbcFTGIA (ORCPT ); Mon, 20 Jun 2016 02:08:00 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3868:3870:4321:5007:6119:6120:10004:10400:10848:11026:11232:11657:11658:11783:11914:12043:12048:12296:12517:12519:12740:13069:13311:13357:13439:13894:14659:14721:21080:21433:30029:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: tooth88_72936370ad921 X-Filterd-Recvd-Size: 1579 Message-ID: <1466402785.19647.138.camel@perches.com> Subject: Re: [RFC PATCH] net: macb: Add gmii2rgmii converter support From: Joe Perches To: Kedareswara rao Appana , nicolas.ferre@atmel.com, punnaia@xilinx.com, harinik@xilinx.com, anirudh@xilinx.com, michals@xilinx.com, appanad@xilinx.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 19 Jun 2016 23:06:25 -0700 In-Reply-To: <1466400437-21277-1-git-send-email-appanad@xilinx.com> References: <1466400437-21277-1-git-send-email-appanad@xilinx.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-06-20 at 10:57 +0530, Kedareswara rao Appana wrote: > This patch adds support for gmii2rgmii converter > in the macb driver. [] > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c [] > @@ -376,6 +389,20 @@ static int macb_mii_probe(struct net_device *dev) >   int phy_irq; >   int ret; >   > + if (bp->gmii2rgmii_phy_node) { > + phydev = of_phy_attach(bp->dev, > +        bp->gmii2rgmii_phy_node, > +        0, 0); > + if (!phydev) { > + dev_err(&bp->pdev->dev, "%s: no gmii_to_rgmii found\n", > + dev->name); why use dev_err(&bp->pdev->dev, ...) and not netdev_err(dev, ...) ?