mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tony Camuso <tcamuso@redhat.com>
To: minyard@acm.org, openipmi-developer@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] ipmi: set si_trydefaults=0 for ARM64
Date: Mon, 20 Jun 2016 13:26:15 -0500	[thread overview]
Message-ID: <1466447175-14263-1-git-send-email-tcamuso@redhat.com> (raw)

Port I/O space does not exist in ARM64 and is not mapped. Attempts to
access it on ARM systems cause stack traces and worse.

Signed-off-by: Tony Camuso <tcamuso@redhat.com>
---
 drivers/char/ipmi/ipmi_si_intf.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 615abbf..85dcc86 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -3841,6 +3841,11 @@ static int init_ipmi_si(void)
 		spmi_find_bmc();
 #endif
 
+#ifdef CONFIG_ARM64
+	/* Don't touch port io space */
+	si_trydefaults = 0;
+#endif
+
 #ifdef CONFIG_PARISC
 	register_parisc_driver(&ipmi_parisc_driver);
 	parisc_registered = true;
-- 
1.8.3.1

             reply	other threads:[~2016-06-20 18:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-20 18:26 Tony Camuso [this message]
2016-06-20 20:57 ` Corey Minyard
2016-06-21 11:20   ` Tony Camuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466447175-14263-1-git-send-email-tcamuso@redhat.com \
    --to=tcamuso@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®