From: He Kuang <hekuang@huawei.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>,
<wangnan0@huawei.com>, <hekuang@huawei.com>,
<jpoimboe@redhat.com>, <ak@linux.intel.com>, <eranian@google.com>,
<namhyung@kernel.org>, <adrian.hunter@intel.com>,
<sukadev@linux.vnet.ibm.com>, <masami.hiramatsu.pt@hitachi.com>,
<tumanova@linux.vnet.ibm.com>, <kan.liang@intel.com>,
<penberg@kernel.org>, <dsahern@gmail.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/5] perf unwind: Change macro names of perf register
Date: Wed, 22 Jun 2016 06:57:02 +0000 [thread overview]
Message-ID: <1466578626-92406-2-git-send-email-hekuang@huawei.com> (raw)
In-Reply-To: <1466578626-92406-1-git-send-email-hekuang@huawei.com>
Use macro name prefixed with "LIBUNWIND_ARCH" for better understanding
that the regs used by callbacks of libunwind are arch specific. The
real regs used should be defined in the wrapper file of
"unwind-libunwind-local.c" for each supported arch.
Signed-off-by: He Kuang <hekuang@huawei.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
---
tools/perf/util/unwind-libunwind-local.c | 6 ++++--
tools/perf/util/unwind.h | 9 +++++++++
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/unwind-libunwind-local.c b/tools/perf/util/unwind-libunwind-local.c
index 01c2e86..97c0f8f 100644
--- a/tools/perf/util/unwind-libunwind-local.c
+++ b/tools/perf/util/unwind-libunwind-local.c
@@ -462,7 +462,8 @@ static int access_mem(unw_addr_space_t __maybe_unused as,
return 0;
}
- ret = perf_reg_value(&start, &ui->sample->user_regs, PERF_REG_SP);
+ ret = perf_reg_value(&start, &ui->sample->user_regs,
+ LIBUNWIND__ARCH_REG_SP);
if (ret)
return ret;
@@ -621,7 +622,8 @@ static int get_entries(struct unwind_info *ui, unwind_entry_cb_t cb,
unw_cursor_t c;
int ret, i = 0;
- ret = perf_reg_value(&val, &ui->sample->user_regs, PERF_REG_IP);
+ ret = perf_reg_value(&val, &ui->sample->user_regs,
+ LIBUNWIND__ARCH_REG_IP);
if (ret)
return ret;
diff --git a/tools/perf/util/unwind.h b/tools/perf/util/unwind.h
index b074662..84c6d44 100644
--- a/tools/perf/util/unwind.h
+++ b/tools/perf/util/unwind.h
@@ -32,6 +32,15 @@ int unwind__get_entries(unwind_entry_cb_t cb, void *arg,
#ifndef LIBUNWIND__ARCH_REG_ID
#define LIBUNWIND__ARCH_REG_ID(regnum) libunwind__arch_reg_id(regnum)
#endif
+
+#ifndef LIBUNWIND__ARCH_REG_SP
+#define LIBUNWIND__ARCH_REG_SP PERF_REG_SP
+#endif
+
+#ifndef LIBUNWIND__ARCH_REG_IP
+#define LIBUNWIND__ARCH_REG_IP PERF_REG_IP
+#endif
+
int LIBUNWIND__ARCH_REG_ID(int regnum);
int unwind__prepare_access(struct thread *thread, struct map *map);
void unwind__flush_access(struct thread *thread);
--
1.8.5.2
next prev parent reply other threads:[~2016-06-22 6:58 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 6:57 [PATCH 0/5] Fixes on perf unwind He Kuang
2016-06-22 6:57 ` He Kuang [this message]
2016-06-26 10:56 ` [tip:perf/core] perf unwind: Change macro names of perf register tip-bot for He Kuang
2016-06-22 6:57 ` [PATCH 2/5] perf unwind: Fix wrongly used regs for x86_32 unwind He Kuang
2016-06-26 10:56 ` [tip:perf/core] " tip-bot for He Kuang
2016-06-22 6:57 ` [PATCH 3/5] perf unwind: Fix wrongly used regs for aarch64 unwind He Kuang
2016-06-26 10:57 ` [tip:perf/core] " tip-bot for He Kuang
2016-06-22 6:57 ` [PATCH 4/5] perf tools: Let python use correct gcc for build_ext He Kuang
2016-06-26 10:54 ` [tip:perf/core] " tip-bot for He Kuang
2016-06-22 6:57 ` [PATCH 5/5] perf tools: Fix NULL pointer deference when vdso not found He Kuang
2016-06-23 2:02 ` Wangnan (F)
2016-06-23 3:03 ` Hekuang
2016-06-23 12:07 ` Arnaldo Carvalho de Melo
2016-06-23 13:28 ` Arnaldo Carvalho de Melo
2016-06-26 10:55 ` [tip:perf/core] perf tools: Find right DSO taking into account if binary is 32 or 64-bit tip-bot for He Kuang
2016-06-23 13:30 ` [PATCH 0/5] Fixes on perf unwind Arnaldo Carvalho de Melo
-- strict thread matches above, loose matches on Subject: below --
2016-05-12 8:43 [PATCH v3 0/7] Add support for remote unwind He Kuang
2016-05-12 8:43 ` [PATCH v3 1/7] perf tools: Set vdso name to vdso[64,32] depending on platform He Kuang
2016-05-12 10:06 ` Adrian Hunter
2016-05-13 8:51 ` [PATCH v3 1/7 UPDATE] perf tools: Find vdso with the consider of cross-platform He Kuang
2016-05-16 13:32 ` Arnaldo Carvalho de Melo
2016-05-17 7:34 ` Adrian Hunter
2016-05-17 7:33 ` Adrian Hunter
2016-05-17 9:04 ` [PATCH v3 1/7 UPDATE2] " He Kuang
2016-05-17 9:17 ` Adrian Hunter
2016-05-17 12:46 ` Arnaldo Carvalho de Melo
2016-06-15 13:34 ` Arnaldo Carvalho de Melo
2016-06-16 0:22 ` Hekuang
2016-06-16 13:00 ` Adrian Hunter
2016-06-16 16:33 ` Arnaldo Carvalho de Melo
2016-05-17 9:05 ` [PATCH v3 1/7 UPDATE] " Hekuang
2016-05-13 8:53 ` [PATCH v3 1/7] perf tools: Set vdso name to vdso[64,32] depending on platform Hekuang
2016-05-12 8:43 ` [PATCH v3 2/7] perf tools: Store vdso buildid unconditionally He Kuang
2016-05-12 13:09 ` Arnaldo Carvalho de Melo
2016-05-20 6:43 ` [tip:perf/urgent] perf symbols: " tip-bot for He Kuang
2016-05-12 8:43 ` [PATCH v3 3/7] perf tools: Remove the logical that skip buildid cache if symfs is given He Kuang
2016-05-12 13:09 ` Arnaldo Carvalho de Melo
2016-05-12 20:23 ` David Ahern
2016-05-12 20:33 ` Arnaldo Carvalho de Melo
2016-05-13 7:19 ` Hekuang
2016-05-13 14:27 ` David Ahern
2016-05-13 18:01 ` Arnaldo Carvalho de Melo
2016-05-14 8:19 ` [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs He Kuang
2016-05-14 14:43 ` David Ahern
2016-05-16 1:30 ` Hekuang
2016-05-16 2:50 ` David Ahern
2016-05-16 6:40 ` Hekuang
2016-05-18 1:47 ` Hekuang
2016-05-18 1:51 ` David Ahern
2016-05-18 2:48 ` Hekuang
2016-05-18 3:04 ` David Ahern
2016-05-12 8:43 ` [PATCH v3 4/7] perf tools: Promote proper messages for cross-platform unwind He Kuang
2016-05-12 8:43 ` [PATCH v3 5/7] perf callchain: Add support " He Kuang
2016-05-12 8:43 ` [PATCH v3 6/7] perf callchain: Support x86 target platform He Kuang
2016-05-12 8:43 ` [PATCH v3 7/7] perf callchain: Support aarch64 cross-platform He Kuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466578626-92406-2-git-send-email-hekuang@huawei.com \
--to=hekuang@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dsahern@gmail.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=jpoimboe@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=sukadev@linux.vnet.ibm.com \
--cc=tumanova@linux.vnet.ibm.com \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®