From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751788AbcFWKDJ (ORCPT ); Thu, 23 Jun 2016 06:03:09 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35662 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751089AbcFWKDF (ORCPT ); Thu, 23 Jun 2016 06:03:05 -0400 From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart Cc: Jan-Marek Glogowski , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] fujitsu-laptop: Debugging cleanup Date: Thu, 23 Jun 2016 12:02:46 +0200 Message-Id: <1466676168-4199-1-git-send-email-kernel@kempniu.pl> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <20160616234630.GB4764@marvin.atrad.com.au> References: <20160616234630.GB4764@marvin.atrad.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jonathan, > > BTW: the debug message is a little misleading, as all of them are prefixed > > 'FUJ02B1', even if the ACPI event is handled by the FUJ02E3 device. > > Yes, good point. The use of "FUJ02B1" (via ACPI_FUJITSU_HID) would have > been for convenience and possibly dates from before FUJ02E3 support was > included in the driver. A case can certainly be made for a more generic > descriptor. vdbg_printk() was introduced by 20b9373, which is the same commit that adds FUJ02E3 support, so it has been the way it is now from the start. This patch series attempts to tidy things up a bit. drivers/platform/x86/fujitsu-laptop.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) -- 1.7.10.4