mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: He Kuang <hekuang@huawei.com>
To: <acme@kernel.org>, <treeze.taeung@gmail.com>,
	<peterz@infradead.org>, <mingo@redhat.com>,
	<alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>
Cc: <mhiramat@kernel.org>, <namhyung@kernel.org>,
	<wangnan0@huawei.com>, <hekuang@huawei.com>,
	<linux-kernel@vger.kernel.org>
Subject: [PATCH] perf tools: Fix compiler error due to header file changes
Date: Sun, 26 Jun 2016 08:40:13 +0000	[thread overview]
Message-ID: <1466930413-21793-1-git-send-email-hekuang@huawei.com> (raw)

The commit 41840d211c51 ("perf config: Move config declarations from
util/cache.h to util/config.h") moved perf_config*(), causes the
following errors when we build with LIBBABELTRACE=1:

  util/data-convert-bt.c: In function ‘convert__config’:
  util/data-convert-bt.c:1269:3: error: implicit declaration of function ‘perf_config_u64’ [-Werror=implicit-function-declaration]
     c->queue_size = perf_config_u64(var, value);
     ^
  util/data-convert-bt.c:1269:3: error: nested extern declaration of ‘perf_config_u64’ [-Werror=nested-externs]
  util/data-convert-bt.c: In function ‘bt_convert__perf2ctf’:
  util/data-convert-bt.c:1302:2: error: implicit declaration of function ‘perf_config’ [-Werror=implicit-function-declaration]
    perf_config(convert__config, &c);
    ^

Include the right header file to fix this.

Signed-off-by: He Kuang <hekuang@huawei.com>
---
 tools/perf/util/data-convert-bt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c
index 4b59879..7b1bc24 100644
--- a/tools/perf/util/data-convert-bt.c
+++ b/tools/perf/util/data-convert-bt.c
@@ -26,6 +26,7 @@
 #include "evlist.h"
 #include "evsel.h"
 #include "machine.h"
+#include "config.h"
 
 #define pr_N(n, fmt, ...) \
 	eprintf(n, debug_data_convert, fmt, ##__VA_ARGS__)
-- 
1.8.5.2

                 reply	other threads:[~2016-06-26  8:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466930413-21793-1-git-send-email-hekuang@huawei.com \
    --to=hekuang@huawei.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=treeze.taeung@gmail.com \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®