From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751812AbcF0B0Z (ORCPT ); Sun, 26 Jun 2016 21:26:25 -0400 Received: from smtprelay0190.hostedemail.com ([216.40.44.190]:53623 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751571AbcF0B0X (ORCPT ); Sun, 26 Jun 2016 21:26:23 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3150:3352:3622:3653:3865:3866:3867:3868:3873:4321:5007:8603:10004:10400:10848:11026:11232:11658:11914:12043:12296:12438:12517:12519:12555:12679:12740:13069:13095:13311:13357:13439:14096:14097:14181:14659:14721:21080:21212:21365:21433:30012:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: wire21_71acb6a897f34 X-Filterd-Recvd-Size: 1971 Message-ID: <1466990779.1847.78.camel@perches.com> Subject: Re: [PATCH] rtlwifi: Add missing newlines to RT_TRACE calls From: Joe Perches To: Larry Finger , Chaoming Li Cc: Kalle Valo , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Sun, 26 Jun 2016 18:26:19 -0700 In-Reply-To: <1466990029.1847.74.camel@perches.com> References: <5677791872bfb47963780c198c825d882456720f.1466969647.git.joe@perches.com> <577070D9.5080503@lwfinger.net> <1466990029.1847.74.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2016-06-26 at 18:13 -0700, Joe Perches wrote: > On Sun, 2016-06-26 at 19:18 -0500, Larry Finger wrote: > > > > On 06/26/2016 02:34 PM, Joe Perches wrote: > > > > > > > > > RT_TRACE does not add a newline to the end of a message and always > > > emits at KERN_DEBUG so these are susceptible to message > > > interleaving > > > from other processes without the newline. > > > > > > Signed-off-by: Joe Perches > > > --- > > This patch does not apply to the wireless-drivers-next repo. Which > > one > > did you use? > linux-next btw: both patches seem to apply to wireless-drivers-next just fine. $ git rev-parse HEAD 1bb57c8a5e33bcbec031ce0c629968922d5af89d $ git am ../next/0001-rtlwifi-Create-_rtl_dbg_trace-function-to-reduce-RT_.patch Applying: rtlwifi: Create _rtl_dbg_trace function to reduce RT_TRACE code size $ git am ../next/0001-rtlwifi-Add-missing-newlines-to-RT_TRACE-calls.patch Applying: rtlwifi: Add missing newlines to RT_TRACE calls