From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853AbcF0Kvl (ORCPT ); Mon, 27 Jun 2016 06:51:41 -0400 Received: from smtprelay0253.hostedemail.com ([216.40.44.253]:46572 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751385AbcF0Kvk (ORCPT ); Mon, 27 Jun 2016 06:51:40 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3871:3873:3874:4321:5007:7875:10004:10400:10848:11232:11658:11783:11914:12048:12517:12519:12663:12740:13069:13095:13161:13229:13311:13357:13439:13894:13972:14659:14721:21080:21212:21433:30054:30076:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: linen00_656d560920f07 X-Filterd-Recvd-Size: 1769 Message-ID: <1467024695.1847.87.camel@perches.com> Subject: Re: powerpc/fadump: trivial fix of spelling mistake, clean up message From: Joe Perches To: Colin Ian King , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Jiri Kosina , Rasmus Villemoes , Andrew Morton , linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org Date: Mon, 27 Jun 2016 03:51:35 -0700 In-Reply-To: <5771021E.3050305@canonical.com> References: <3rcf3g63Wnz9s5Q@ozlabs.org> <5771021E.3050305@canonical.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote: > On 26/06/16 05:19, Michael Ellerman wrote: > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote: [] > > > trivial fix to spelling mistake "rgistration" and minor clean up > > > of the printk error message > > Can you also: > >  - use pr_err() > >  - unsplit the message, ie. keep the string all on one line. > I can unsplit the string, but checkpatch will complain about that, so > I'm not sure if that's preferred or not. > > WARNING: line over 80 characters If the statement is wrapped after the format, then checkpatch shouldn't complain. pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n",        rc);