From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751906AbcF0LOX (ORCPT ); Mon, 27 Jun 2016 07:14:23 -0400 Received: from smtprelay0174.hostedemail.com ([216.40.44.174]:55337 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751644AbcF0LOW (ORCPT ); Mon, 27 Jun 2016 07:14:22 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3353:3622:3653:3865:3867:3868:3870:3871:3872:3873:3874:4250:4321:5007:8784:10004:10400:10848:11026:11232:11657:11658:11783:11914:12043:12296:12517:12519:12555:12740:13069:13095:13161:13229:13311:13357:13439:13894:14181:14659:14721:21080:21433:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:3,LUA_SUMMARY:none X-HE-Tag: rice74_8b3d1d3a0c03 X-Filterd-Recvd-Size: 2678 Message-ID: <1467026058.1847.95.camel@perches.com> Subject: Re: [PATCH 2/7] efi: Document #define FOO_PROTOCOL_GUID layout From: Joe Perches To: Ingo Molnar , Matt Fleming Cc: Thomas Gleixner , "H . Peter Anvin" , Peter Jones , Ard Biesheuvel , linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org Date: Mon, 27 Jun 2016 04:14:18 -0700 In-Reply-To: <20160627104920.GA9099@gmail.com> References: <1466839230-12781-1-git-send-email-matt@codeblueprint.co.uk> <1466839230-12781-3-git-send-email-matt@codeblueprint.co.uk> <20160627104920.GA9099@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-06-27 at 12:49 +0200, Ingo Molnar wrote: > * Matt Fleming wrote: [] > > + * EFI Configuration Table and GUID definitions > > + * > > + * These should be formatted roughly like the ones in the UEFI SPEC has > > + * them.  It makes them easier to grep for, and they look the same when > > + * you're staring at them. [] > Btw., another possible way to organize the GUIDs would be to ignore checkpatch (we  > should ignore checkpatch when it's wrong) Completely agree. checkpatch is brainless. > and go for a nice table format: >  > #define NULL_GUID EFI_GUID(0x00000000, 0x0000, 0x0000,  0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00) Much nicer. There are a few more files that use EFI_GUID. It'd be good to standardize. $ git grep --name-only -w EFI_GUID arch/ia64/include/asm/sal.h arch/ia64/kernel/esi.c arch/x86/platform/efi/quirks.c block/partitions/efi.h drivers/infiniband/hw/hfi1/efivar.c drivers/scsi/isci/probe_roms.h include/linux/efi.h Maybe a checkpatch line-length exclusion: ---  scripts/checkpatch.pl | 4 ++++  1 file changed, 4 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 4904ced..cc787e6 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2764,6 +2764,10 @@ sub process {    $line =~ /^\+\s*#\s*define\s+\w+\s+$String$/) {   $msg_type = "";   + # EFI_GUID is another special case + } elsif ($line =~ /^\+.*\bEFI_GUID\s*\(/) { + $msg_type = ""; +   # Otherwise set the alternate message types     # a comment starts before $max_line_length