From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbcF0LdJ (ORCPT ); Mon, 27 Jun 2016 07:33:09 -0400 Received: from smtprelay0246.hostedemail.com ([216.40.44.246]:50151 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751655AbcF0LdI (ORCPT ); Mon, 27 Jun 2016 07:33:08 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2693:2828:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4321:5007:7875:10004:10400:10848:11232:11658:11783:11914:12048:12517:12519:12663:12740:13069:13095:13161:13229:13311:13357:13439:13894:13972:14659:14721:21080:21212:21433:30054:30076:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: burn09_1ac6d920bc847 X-Filterd-Recvd-Size: 2437 Message-ID: <1467027183.1847.98.camel@perches.com> Subject: Re: powerpc/fadump: trivial fix of spelling mistake, clean up message From: Joe Perches To: Michael Ellerman , Colin Ian King , Benjamin Herrenschmidt , Paul Mackerras , Jiri Kosina , Rasmus Villemoes , Andrew Morton , linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org Date: Mon, 27 Jun 2016 04:33:03 -0700 In-Reply-To: <1467026427.29808.4.camel@ellerman.id.au> References: <3rcf3g63Wnz9s5Q@ozlabs.org> <5771021E.3050305@canonical.com> <1467024695.1847.87.camel@perches.com> <1467026427.29808.4.camel@ellerman.id.au> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.2-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-06-27 at 21:20 +1000, Michael Ellerman wrote: > On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote: > > > > On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote: > > > > > > On 26/06/16 05:19, Michael Ellerman wrote: > > > > > > > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote: > > > > > > > > > > trivial fix to spelling mistake "rgistration" and minor clean up > > > > > of the printk error message > > > > Can you also: > > > >  - use pr_err() > > > >  - unsplit the message, ie. keep the string all on one line. > > > I can unsplit the string, but checkpatch will complain about that, so > > > I'm not sure if that's preferred or not. > > > > > > WARNING: line over 80 characters > > If the statement is wrapped after the format, > > then checkpatch shouldn't complain. > > > > pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n", > >        rc); > But that's not actually any more readable, so just ignore checkpatch in this > case IMHO. It's a guide, not the gospel. Absolutely.  Ignore checkpatch whenever appropriate. There are relatively few lines in kernel source that have printk arguments post format that extend beyond 80 columns though and standardization is also good. cheers back.