From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752068AbcF0R2a (ORCPT ); Mon, 27 Jun 2016 13:28:30 -0400 Received: from mga04.intel.com ([192.55.52.120]:47425 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbcF0R2Z (ORCPT ); Mon, 27 Jun 2016 13:28:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,537,1459839600"; d="scan'208";a="836080850" Message-ID: <1467048594.8970.81.camel@linux.intel.com> Subject: Re: [PATCH v2 3/3] intel_pstate: Declare pid_params/pstate_funcs/hwp_active __read_mostly From: Srinivas Pandruvada To: Jisheng Zhang , lenb@kernel.org, rjw@rjwysocki.net, viresh.kumar@linaro.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 27 Jun 2016 10:29:54 -0700 In-Reply-To: <1467022038-924-4-git-send-email-jszhang@marvell.com> References: <1467022038-924-1-git-send-email-jszhang@marvell.com> <1467022038-924-4-git-send-email-jszhang@marvell.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2 (3.18.5.2-1.fc23) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2016-06-27 at 18:07 +0800, Jisheng Zhang wrote: > pid_params is written once by copy_pid_params() during > initialization, > and thereafter is mostly read by hot path intel_pstate_update_util(). > The read of pid_params gets more after commit a4675fbc4a7a ("cpufreq: > intel_pstate: Replace timers with utilization update callbacks") > > pstate_funcs is written once by copy_cpu_funcs() during > initialization, > and thereafter is mostly read by hot path intel_pstate_update_util() > > hwp_active is written to once during initialization and thereafter is > mostly read by hot path intel_pstate_update_util(). > > The fact that they are mostly read and not written to makes them > candidates for __read_mostly declarations. > > Signed-off-by: Jisheng Zhang Acked-by: Srinivas Pandruvada > --- >  drivers/cpufreq/intel_pstate.c | 6 +++--- >  1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/cpufreq/intel_pstate.c > b/drivers/cpufreq/intel_pstate.c > index 861bcba..2eda50d 100644 > --- a/drivers/cpufreq/intel_pstate.c > +++ b/drivers/cpufreq/intel_pstate.c > @@ -281,9 +281,9 @@ struct cpu_defaults { >  static inline int32_t get_target_pstate_use_performance(struct > cpudata *cpu); >  static inline int32_t get_target_pstate_use_cpu_load(struct cpudata > *cpu); >   > -static struct pstate_adjust_policy pid_params; > -static struct pstate_funcs pstate_funcs; > -static int hwp_active; > +static struct pstate_adjust_policy pid_params __read_mostly; > +static struct pstate_funcs pstate_funcs __read_mostly; > +static int hwp_active __read_mostly; >   >  #ifdef CONFIG_ACPI >  static bool acpi_ppc;