From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752122AbcF1CmR (ORCPT ); Mon, 27 Jun 2016 22:42:17 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:42525 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751673AbcF1CmJ (ORCPT ); Mon, 27 Jun 2016 22:42:09 -0400 X-AuditID: cbfee68d-f79876d000001436-b4-5771e3d81e36 From: Andi Shyti To: Kukjin Kim , Krzysztof Kozlowski , Mark Brown Cc: Jaehoon Chung , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH v2 0/5] s3c64xx: consider the case of a disconnected CS line and some code rework Date: Tue, 28 Jun 2016 11:41:10 +0900 Message-id: <1467081676-8442-1-git-send-email-andi.shyti@samsung.com> X-Mailer: git-send-email 2.8.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrELMWRmVeSWpSXmKPExsWyRsSkUPfG48JwgwsHrC22H3nGarH4x3Mm i6kPn7BZ3PjVxmrx+oWhRf/j18wWmx5fY7W4vGsOm8WM8/uYLBo/3mR34PK4vuQTs8emVZ1s HpuX1Hv0bVnF6PF5k1wAaxSXTUpqTmZZapG+XQJXxscvUxgLOnkqPu77x97AOIOzi5GTQ0LA RGJP/292CFtM4sK99WxdjFwcQgIrGCW6/pxhhSl6teQTO0RiFqPEwqXHWSCcj4wSjZ8vsIBU sQloSjTd/sEGYosIFEs8ufqfFaSIWeAbo8SCkxMZQRLCAskSB2ZsARvLIqAq8avnNlgzr4Cr xLdfexkh1slJXJ7+AOwOCYF57BIXpy1khmgQkPg2+RBQAwdQQlZi0wFmiHpJiYMrbrBMYBRc wMiwilE0tSC5oDgpvchQrzgxt7g0L10vOT93EyMwqE//e9a7g/H2AetDjAIcjEo8vBcmF4YL sSaWFVfmHmI0BdowkVlKNDkfGDt5JfGGxmZGFqYmpsZG5pZmSuK8ilI/g4UE0hNLUrNTUwtS i+KLSnNSiw8xMnFwSjUwhjLabbS790bhft7sdR8tW8zeTfm/Revnpn2ql7faOEkGBJrwr0m8 ure4jZHxwuM1CxtZXqfrHtps/E39Ws5pLcYbbbOTjVjXlBlGrxF8JJa5ft/pygDRk+KBJ/dt vMe/KGqzXkPD0sPBM+t1pFTsIrR272/Qm3Kqb6cSW+etzxmvH/2doMnZpMRSnJFoqMVcVJwI ACBP+ytlAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprPIsWRmVeSWpSXmKPExsVy+t9jQd0bjwvDDa6fkLbYfuQZq8XiH8+Z LKY+fMJmceNXG6vF6xeGFv2PXzNbbHp8jdXi8q45bBYzzu9jsmj8eJPdgcvj+pJPzB6bVnWy eWxeUu/Rt2UVo8fnTXIBrFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5 ibmptkouPgG6bpk5QEcpKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwlrGDM+ fpnCWNDJU/Fx3z/2BsYZnF2MnBwSAiYSr5Z8YoewxSQu3FvP1sXIxSEkMItRYuHS4ywQzkdG icbPF1hAqtgENCWabv9gA7FFBIolnlz9zwpSxCzwjVFiwcmJjCAJYYFkiQMztrCC2CwCqhK/ em6DNfMKuEp8+7WXEWKdnMTl6Q/YJjByL2BkWMUokVqQXFCclJ5rlJdarlecmFtcmpeul5yf u4kRHDnPpHcwHt7lfohRgINRiYf3wuTCcCHWxLLiytxDjBIczEoivFmPgEK8KYmVValF+fFF pTmpxYcYTYEOmMgsJZqcD4zqvJJ4Q2MTMyNLI3NDCyNjcyVx3sf/14UJCaQnlqRmp6YWpBbB 9DFxcEoBQ6n4SlvTHkumyhNblNNEJtXPfnlWMmvzW1HJKVN4F1hN1jU0ehVmL6rpbqwh82XC I7OLP8445zxc55Gw997rOaa7lh3YuMr31M5q/WVV83Ya2vCvvPjDr35Z7IxdGsK8jQ5zD2Us Z72sHxSTO+vGHuUNGxL5Qt7NLN+6RGX5np9hl25NuskjvkaJpTgj0VCLuag4EQCp9HgasgIA AA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, the main goal of the patchset is to support SPI cnnected device without CS line link. The first two patches make the s3c64xx driver to consider the case of a disconnected CS line. This is done by adding a property in the DTS ("no-cs-readback") which informs the device driver the absence of a chip selection link. The last three patches are just some code re-work and beautification. Changelog: V1 -> V2 - the first version of the patchset was removing an 'if' statement on "!spi->chip_select" which was causing the SPI core to fail. In this case the drivers would have been able to set a chip_select = 0 in absence of a CS link. After a short discussion with Mark, this has been replaced, as described above, by a property in the DTS. - one more patch has been added which assigns to some variable the proper type - some typos fixed in the commit messages Thanks, Andi Andi Shyti (5): spi: s3c64xx: group the CS signalling writes in a single function spi: s3c64xx: consider the case when the CS line is not connected spi: s3c64xx: do not configure the device twice spi: s3c64xx: simplify if statement in prepare_transfer function spi: s3c64xx: use unsigned type for fifo handling variables .../devicetree/bindings/spi/spi-samsung.txt | 3 + drivers/spi/spi-s3c64xx.c | 114 +++++++++++---------- include/linux/platform_data/spi-s3c64xx.h | 1 + 3 files changed, 65 insertions(+), 53 deletions(-) -- 2.8.1