From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752214AbcF1CnI (ORCPT ); Mon, 27 Jun 2016 22:43:08 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:44672 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751862AbcF1CmL (ORCPT ); Mon, 27 Jun 2016 22:42:11 -0400 X-AuditID: cbfee68d-f79876d000001436-b7-5771e3d96252 From: Andi Shyti To: Kukjin Kim , Krzysztof Kozlowski , Mark Brown Cc: Jaehoon Chung , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti , Andi Shyti Subject: [PATCH v2 5/5] spi: s3c64xx: use unsigned type for fifo handling variables Date: Tue, 28 Jun 2016 11:41:15 +0900 Message-id: <1467081676-8442-6-git-send-email-andi.shyti@samsung.com> X-Mailer: git-send-email 2.8.1 In-reply-to: <1467081676-8442-1-git-send-email-andi.shyti@samsung.com> References: <1467081676-8442-1-git-send-email-andi.shyti@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrFLMWRmVeSWpSXmKPExsWyRsSkUPfm48Jwg62dghbbjzxjtVj84zmT xdSHT9gsbvxqY7V4/cLQov/xa2aLTY+vsVpc3jWHzWLG+X1MFo0fb7I7cHlcX/KJ2WPTqk42 j81L6j36tqxi9Pi8SS6ANYrLJiU1J7MstUjfLoErY9GFNewF1zkqJn3az9rA2M/excjJISFg IvFo8SIWCFtM4sK99WxdjFwcQgIrGCU23vjFClP0adpdFojELEaJV3ufMUM4HxklGj9fAGtn E9CUaLr9gw3EFhEolnhy9T8rSBGzwDdGiQUnJzKCJIQFQiX6lxxkBrFZBFQl5h7dB7aCV8BV YsfGzVB3yElcnv4AbBCngJvEjn2nwGqEgGrWz1oGNlRCYBO7RPO5yywQgwQkvk0+BGRzACVk JTYdYIaYIylxcMUNlgmMwgsYGVYxiqYWJBcUJ6UXGeoVJ+YWl+al6yXn525iBEbB6X/Pencw 3j5gfYhRgINRiYf3wuTCcCHWxLLiytxDjKZAGyYyS4km5wNjLa8k3tDYzMjC1MTU2Mjc0kxJ nFdR6mewkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBsaMr6zb5olvM9rNXr/tQaiJ6r65p39I z/V4sWK376b7l9kmBU6rUX7ToLqv+iHjs5aOQ5L5a3wyi1wy0vo1juwznCQt3RTwx+01+8zI B8/PnNkoxz+5xzuhYPK61bvesn49I1y8bF3EzI9t6qGTL/XEfCuviSv9mOH0lSssqnCly8PP B+O4HBcqsRRnJBpqMRcVJwIAhiYy3X0CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOIsWRmVeSWpSXmKPExsVy+t9jQd2bjwvDDWY+YbLYfuQZq8XiH8+Z LKY+fMJmceNXG6vF6xeGFv2PXzNbbHp8jdXi8q45bBYzzu9jsmj8eJPdgcvj+pJPzB6bVnWy eWxeUu/Rt2UVo8fnTXIBrFENjDYZqYkpqUUKqXnJ+SmZeem2St7B8c7xpmYGhrqGlhbmSgp5 ibmptkouPgG6bpk5QEcpKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwlrGDMW XVjDXnCdo2LSp/2sDYz97F2MnBwSAiYSn6bdZYGwxSQu3FvP1sXIxSEkMItR4tXeZ8wQzkdG icbPF8Cq2AQ0JZpu/2ADsUUEiiWeXP3PClLELPCNUWLByYmMIAlhgVCJ/iUHmUFsFgFViblH 97GC2LwCrhI7Nm6GWicncXn6A7BBnAJuEjv2nQKrEQKqWT9rGesERt4FjAyrGCVSC5ILipPS c43yUsv1ihNzi0vz0vWS83M3MYIj7Zn0DsbDu9wPMQpwMCrx8F6YXBguxJpYVlyZe4hRgoNZ SYQ36xFQiDclsbIqtSg/vqg0J7X4EKMp0GETmaVEk/OBSSCvJN7Q2MTMyNLI3NDCyNhcSZz3 8f91YUIC6YklqdmpqQWpRTB9TBycUg2MXDNypxzf8eSN7UKP208W7OXeI8XAu//ViW2eyQ83 tN/sWaPy4aFDj7lE0mu9xaYbV+SxT5g7662Z3IKcTSzvig4mzxP59vHcR+1/jJVNP8Oz+i9J 5EfM1F+Q+sepxfHhhe+++pYPxU7E1Qdqut9jy1zE4fV3dmeLUsRlgcJlrIZRWz/5NHxbqsRS nJFoqMVcVJwIAN8s8ZjKAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The 'quirks' variable cannot ever be negative, therefore use u8 instead of int. The 8 bit size is given from the fact that currently the quirks variable has very few statuses. The rx_lvl_offset and tx_st_done store shift values, so that u8 is a proper size. fifo_lvl_mask stores a series of masks, to be in we will keep the 32 bit size. Signed-off-by: Andi Shyti Signed-off-by: Jaehoon Chung --- drivers/spi/spi-s3c64xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 6d8486f..6c9503a 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -150,10 +150,10 @@ struct s3c64xx_spi_dma_data { * which is provided as driver data to the driver. */ struct s3c64xx_spi_port_config { - int fifo_lvl_mask[MAX_SPI_PORTS]; - int rx_lvl_offset; - int tx_st_done; - int quirks; + u32 fifo_lvl_mask[MAX_SPI_PORTS]; + u8 rx_lvl_offset; + u8 tx_st_done; + u8 quirks; bool high_speed; bool clk_from_cmu; }; -- 2.8.1