From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752023AbcF1DuQ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 27 Jun 2016 23:50:16 -0400
Received: from ozlabs.org ([103.22.144.67]:44711 "EHLO ozlabs.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751673AbcF1DuO (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 27 Jun 2016 23:50:14 -0400
Message-ID: <1467085812.32607.3.camel@ellerman.id.au>
Subject: Re: powerpc/fadump: trivial fix of spelling mistake, clean up
 message
From: Michael Ellerman <mpe@ellerman.id.au>
To: Colin Ian King <colin.king@canonical.com>, Joe Perches <joe@perches.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Paul Mackerras <paulus@samba.org>, Jiri Kosina <trivial@kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Andrew Morton <akpm@linux-foundation.org>,
        linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org
Date: Tue, 28 Jun 2016 13:50:12 +1000
In-Reply-To: <57710F50.2070800@canonical.com>
References: <3rcf3g63Wnz9s5Q@ozlabs.org> <5771021E.3050305@canonical.com>
	 <1467024695.1847.87.camel@perches.com>
	 <1467026427.29808.4.camel@ellerman.id.au> <57710F50.2070800@canonical.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.16.5-1ubuntu3.1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2016-06-27 at 12:34 +0100, Colin Ian King wrote:
> On 27/06/16 12:20, Michael Ellerman wrote:
> > On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote:
> > > On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote:
> > > > On 26/06/16 05:19, Michael Ellerman wrote:
> > > > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote:
> > > > > > trivial fix to spelling mistake "rgistration" and minor clean up
> > > > > > of the printk error message
> > > > > Can you also:
> > > > >  - use pr_err()
> > > > >  - unsplit the message, ie. keep the string all on one line.
> > > > I can unsplit the string, but checkpatch will complain about that, so
> > > > I'm not sure if that's preferred or not.
> > > > 
> > > > WARNING: line over 80 characters
> > > 
> > > If the statement is wrapped after the format,
> > > then checkpatch shouldn't complain.
> > > 
> > > 	pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n",
> > > 	       rc);
> > 
> > But that's not actually any more readable, so just ignore checkpatch in this
> > case IMHO. It's a guide, not the gospel.
>
> OK, so shall I'll send a V3 w/o the spit and the pr_err fix?

Nah that's fine, I already grabbed v2.

cheers