mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yury Norov <ynorov@caviumnetworks.com>
To: <libc-alpha@sourceware.org>, <linux-kernel@vger.kernel.org>
Cc: <arnd@arndb.de>, <catalin.marinas@arm.com>,
	<marcus.shawcroft@arm.com>, <philb@gnu.org>,
	<davem@davemloft.net>, <szabolcs.nagy@arm.com>,
	<maxim.kuvyrkov@linaro.org>, <joseph@codesourcery.com>,
	<pinskia@gmail.com>, <bamvor.zhangjian@huawei.com>,
	<schwab@suse.de>, <fweimer@redhat.com>,
	<Prasun.Kapoor@cavium.com>, <cmetcalf@mellanox.com>,
	<hjl.tools@gmail.com>, <adhemerval.zanella@linaro.org>,
	Andrew Pinski <apinski@cavium.com>,
	Yury Norov <ynorov@caviumnetworks.com>
Subject: [PATCH 06/23] [AARCH64] Use PTR_REG/PTR_SIZE/PTR_SIZE_LOG in dl-tlsesc.S
Date: Tue, 28 Jun 2016 19:39:21 +0300	[thread overview]
Message-ID: <1467131978-669-7-git-send-email-ynorov@caviumnetworks.com> (raw)
In-Reply-To: <1467131978-669-1-git-send-email-ynorov@caviumnetworks.com>

From: Andrew Pinski <apinski@cavium.com>

This converts dl-tlsdesc.S code over to use the new macros which allows for
sharing between ILP32 and LP64 code.

* sysdeps/aarch64/dl-tlsdesc.S (_dl_tlsdesc_return): Use PTR_REG.
(_dl_tlsdesc_dynamic)		: Use PTR_REG, PTR_SIZE.
(_dl_tlsdesc_resolve_hold)	: Likewise.
(_dl_tlsdesc_resolve_rela)	: Likewise.
(_dl_tlsdesc_return_lazy)	: Likewise.
(_dl_tlsdesc_undefweak)		: Likewise.

Signed-off-by: Yury Norov <ynorov@caviumnetworks.com>
---
 sysdeps/aarch64/dl-tlsdesc.S | 48 ++++++++++++++++++++++----------------------
 1 file changed, 24 insertions(+), 24 deletions(-)

diff --git a/sysdeps/aarch64/dl-tlsdesc.S b/sysdeps/aarch64/dl-tlsdesc.S
index 05be370..09cd158 100644
--- a/sysdeps/aarch64/dl-tlsdesc.S
+++ b/sysdeps/aarch64/dl-tlsdesc.S
@@ -74,7 +74,7 @@
 	cfi_startproc
 	.align 2
 _dl_tlsdesc_return:
-	ldr	x0, [x0, #8]
+	ldr	PTR_REG (0), [x0, #PTR_SIZE]
 	RET
 	cfi_endproc
 	.size	_dl_tlsdesc_return, .-_dl_tlsdesc_return
@@ -95,9 +95,9 @@ _dl_tlsdesc_return_lazy:
 	   so it reads the same value (this function is the final value of
 	   td->entry) and thus it synchronizes with the release store to
 	   td->entry in _dl_tlsdesc_resolve_rela_fixup ensuring that the load
-	   from [x0,#8] here happens after the initialization of td->arg.  */
-	ldar	xzr, [x0]
-	ldr	x0, [x0, #8]
+	   from [x0,#PTR_SIZE] here happens after the initialization of td->arg. */
+	ldar	PTR_REG (zr), [x0]
+	ldr	PTR_REG (0), [x0, #PTR_SIZE]
 	RET
 	cfi_endproc
 	.size	_dl_tlsdesc_return_lazy, .-_dl_tlsdesc_return_lazy
@@ -125,10 +125,10 @@ _dl_tlsdesc_undefweak:
 	   td->entry) and thus it synchronizes with the release store to
 	   td->entry in _dl_tlsdesc_resolve_rela_fixup ensuring that the load
 	   from [x0,#8] here happens after the initialization of td->arg.  */
-	ldar	xzr, [x0]
-	ldr	x0, [x0, #8]
+	ldar	PTR_REG (zr), [x0]
+	ldr	PTR_REG (0), [x0, #PTR_SIZE]
 	mrs	x1, tpidr_el0
-	sub	x0, x0, x1
+	sub	PTR_REG (0), PTR_REG (0), PTR_REG (1)
 	ldr	x1, [sp], #16
 	cfi_adjust_cfa_offset (-16)
 	RET
@@ -187,22 +187,22 @@ _dl_tlsdesc_dynamic:
 	   so it reads the same value (this function is the final value of
 	   td->entry) and thus it synchronizes with the release store to
 	   td->entry in _dl_tlsdesc_resolve_rela_fixup ensuring that the load
-	   from [x0,#8] here happens after the initialization of td->arg.  */
-	ldar	xzr, [x0]
-	ldr	x1, [x0,#8]
-	ldr	x0, [x4]
-	ldr	x3, [x1,#16]
-	ldr	x2, [x0]
-	cmp	x3, x2
+	   from [x0,#PTR_SIZE] here happens after the initialization of td->arg.  */
+	ldar	PTR_REG (zr), [x0]
+	ldr	PTR_REG (1), [x0,#PTR_SIZE]
+	ldr	PTR_REG (0), [x4]
+	ldr	PTR_REG (3), [x1,#(PTR_SIZE * 2)]
+	ldr	PTR_REG (2), [x0]
+	cmp	PTR_REG (3), PTR_REG (2)
 	b.hi	2f
-	ldr	x2, [x1]
-	add	x0, x0, x2, lsl #4
-	ldr	x0, [x0]
+	ldr	PTR_REG (2), [x1]
+	add	PTR_REG (0), PTR_REG (0), PTR_REG (2), lsl #(PTR_LOG_SIZE + 1)
+	ldr	PTR_REG (0), [x0]
 	cmn	x0, #0x1
 	b.eq	2f
-	ldr	x1, [x1,#8]
-	add	x0, x0, x1
-	sub	x0, x0, x4
+	ldr	PTR_REG (1), [x1,#(PTR_SIZE * 2)]
+	add	PTR_REG (0), PTR_REG (0), PTR_REG (1)
+	sub	PTR_REG (0), PTR_REG (0), PTR_REG (4)
 1:
 	ldp	 x1,  x2, [sp, #32+16*0]
 	ldp	 x3,  x4, [sp, #32+16*1]
@@ -233,7 +233,7 @@ _dl_tlsdesc_dynamic:
 	bl	__tls_get_addr
 
 	mrs	x1, tpidr_el0
-	sub	x0, x0, x1
+	sub	PTR_REG (0), PTR_REG (0), PTR_REG (1)
 
 	RESTORE_Q_REGISTERS
 
@@ -279,13 +279,13 @@ _dl_tlsdesc_resolve_rela:
 
 	SAVE_Q_REGISTERS
 
-	ldr	x1, [x3, #8]
+	ldr	PTR_REG (1), [x3, #PTR_SIZE]
 	bl	_dl_tlsdesc_resolve_rela_fixup
 
 	RESTORE_Q_REGISTERS
 
 	ldr	x0, [sp, #32+16*8]
-	ldr	x1, [x0]
+	ldr	PTR_REG (1), [x0]
 	blr	x1
 
 	ldp	 x1,  x4, [sp, #32+16*0]
@@ -346,7 +346,7 @@ _dl_tlsdesc_resolve_hold:
 	RESTORE_Q_REGISTERS
 
 	ldr	x0, [sp, #32+16*9]
-	ldr	x1, [x0]
+	ldr	PTR_REG (1), [x0]
 	blr	x1
 
 	ldp	 x1,  x2, [sp, #32+16*0]
-- 
2.7.4

  parent reply	other threads:[~2016-06-28 16:41 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 16:39 [RFC2 PATCH 00/23] ARM64: support ILP32 Yury Norov
2016-06-28 16:39 ` [PATCH 01/23] [AARCH64] define word size for lp64 and ilp32 Yury Norov
2016-06-28 17:00   ` Joseph Myers
2016-06-28 17:30     ` Joseph Myers
2016-06-28 16:39 ` [PATCH 02/23] [AARCH64] Add header guards to sysdep.h headers Yury Norov
2016-06-28 16:39 ` [PATCH 03/23] Add dynamic ILP32 AARCH64 relocations to elf.h Yury Norov
2016-06-28 17:03   ` Joseph Myers
2016-06-28 16:39 ` [PATCH 04/23] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE. Use it in LDST_PCREL and LDST_GLOBAL Yury Norov
2016-06-28 16:39 ` [PATCH 05/23] [AARCH64] Use PTR_REG in crti.S Yury Norov
2016-06-28 17:05   ` Joseph Myers
2016-06-28 16:39 ` Yury Norov [this message]
2016-06-28 17:06   ` [PATCH 06/23] [AARCH64] Use PTR_REG/PTR_SIZE/PTR_SIZE_LOG in dl-tlsesc.S Joseph Myers
2016-06-28 16:39 ` [PATCH 07/23] [AARCH64] Use PTR_* macros in dl-trampoline.S Yury Norov
2016-06-28 16:39 ` [PATCH 08/23] [AARCH64] Use PTR_* in start.S Yury Norov
2016-06-28 16:39 ` [PATCH 09/23] [AARCH64] Use PTR_REG in getcontext.S Yury Norov
2016-06-28 16:39 ` [PATCH 10/23] [AARCH64] Detect ILP32 in configure scripts Yury Norov
2016-06-28 17:07   ` Joseph Myers
2016-06-28 17:26     ` Yury Norov
2016-06-28 17:35       ` Joseph Myers
2016-06-28 16:39 ` [PATCH 11/23] [AARCH64] Add ILP32 support to elf_machine_load_address Yury Norov
2016-06-28 16:39 ` [PATCH 12/23] [AARCH64] Add ILP32 to makefiles Yury Norov
2016-06-28 16:39 ` [PATCH 13/23] [AARCH64] Add support to ldconfig for ILP32 and libilp32 Yury Norov
2016-06-28 16:39 ` [PATCH 14/23] [AARCH64] Add ILP32 ld.so to the known interpreter names Yury Norov
2016-06-28 16:39 ` [PATCH 15/23] [AARCH64] Add ldd-rewrite.sed so that ilp32 ld.so can be found Yury Norov
2016-06-28 16:39 ` [PATCH 16/23] [AARCH64] Make lp64 and ilp32 directories Yury Norov
2016-06-28 17:10   ` Joseph Myers
2016-06-29  8:43   ` Andreas Schwab
2016-06-28 16:39 ` [PATCH 17/23] [AARCH64] ILP32: introduce syscalls that pass off_t Yury Norov
2016-06-28 17:13   ` Joseph Myers
2016-06-29 10:10   ` Andreas Schwab
2016-06-29 12:04     ` Andreas Schwab
2016-06-28 16:39 ` [PATCH 18/23] [AARCH64] ILP32: support stat syscall family Yury Norov
2016-06-28 17:15   ` Joseph Myers
2016-06-28 19:08     ` Yury Norov
2016-06-28 20:41       ` Adhemerval Zanella
2016-06-28 20:46       ` Joseph Myers
2016-06-29  6:57   ` Andreas Schwab
2016-06-29  9:20   ` Andreas Schwab
2016-06-28 16:39 ` [PATCH 19/23] [AARCH64] delouse input arguments in system functions Yury Norov
2016-06-28 17:15   ` Joseph Myers
2016-06-29  7:49   ` Andreas Schwab
2016-06-28 16:39 ` [PATCH 20/23] [AARCH64] Fix ILP32 warning Yury Norov
2016-06-28 16:39 ` [PATCH 21/23] [AARCH64] Make __SIZEOF_SEM_T 16 for ILP32 Yury Norov
2016-06-28 17:16   ` Joseph Myers
2016-06-29  7:55   ` Andreas Schwab
2016-06-28 16:39 ` [PATCH 22/23] off_t: fix register pair calculation for 64-bit case Yury Norov
2016-06-28 17:17   ` Joseph Myers
2016-06-28 16:39 ` [PATCH 23/23] [AARCH64] Take utmp{,x}.h from s390 port Yury Norov
2016-06-28 17:18   ` Joseph Myers
2016-06-28 17:59     ` Yury Norov
2016-06-28 20:38       ` Joseph Myers
2016-06-28 20:43       ` Adhemerval Zanella
2016-06-28 16:57 ` [RFC2 PATCH 00/23] ARM64: support ILP32 Joseph Myers
2016-06-28 17:31 ` Adhemerval Zanella
2016-07-05  7:33 ` Andreas Schwab
2016-07-08 15:12 ` Yury Norov
2016-09-08  4:25 ` Zhangjian (Bamvor)
2016-09-08 11:37   ` Yury Norov
2016-09-08 11:51     ` Zhangjian (Bamvor)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467131978-669-7-git-send-email-ynorov@caviumnetworks.com \
    --to=ynorov@caviumnetworks.com \
    --cc=Prasun.Kapoor@cavium.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=apinski@cavium.com \
    --cc=arnd@arndb.de \
    --cc=bamvor.zhangjian@huawei.com \
    --cc=catalin.marinas@arm.com \
    --cc=cmetcalf@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=fweimer@redhat.com \
    --cc=hjl.tools@gmail.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcus.shawcroft@arm.com \
    --cc=maxim.kuvyrkov@linaro.org \
    --cc=philb@gnu.org \
    --cc=pinskia@gmail.com \
    --cc=schwab@suse.de \
    --cc=szabolcs.nagy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®