From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751781AbcF2U1t (ORCPT ); Wed, 29 Jun 2016 16:27:49 -0400 Received: from lists.s-osg.org ([54.187.51.154]:59613 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbcF2U1s (ORCPT ); Wed, 29 Jun 2016 16:27:48 -0400 From: Luis de Bethencourt To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, salah.triki@gmail.com, viro@zeniv.linux.org.uk, mhocko@suse.com, vdavydov@virtuozzo.com, Luis de Bethencourt Subject: [PATCH 1/2] fs: befs: check silent flag before logging error Date: Wed, 29 Jun 2016 21:27:40 +0100 Message-Id: <1467232061-5600-1-git-send-email-luisbg@osg.samsung.com> X-Mailer: git-send-email 2.5.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Log error only when silent flag is not set. Fixes: dbe6460388bc ("fs/befs/linuxvfs.c: check silent flag before logging errors") Signed-off-by: Luis de Bethencourt --- Hi, Reading the backlog of latest patches to befs, I noticed that Salah's patch missed one call to befs_error() when setting all to only be used when the silent argument is false. Thanks, Luis fs/befs/linuxvfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index b700645..bf5658d 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c @@ -790,7 +790,8 @@ befs_fill_super(struct super_block *sb, void *data, int silent) */ blocksize = sb_min_blocksize(sb, 1024); if (!blocksize) { - befs_error(sb, "unable to set blocksize"); + if (!silent) + befs_error(sb, "unable to set blocksize"); goto unacquire_priv_sbp; } -- 2.5.1