From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752166AbcGAAHk (ORCPT ); Thu, 30 Jun 2016 20:07:40 -0400 Received: from lists.s-osg.org ([54.187.51.154]:45161 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750924AbcGAAHk (ORCPT ); Thu, 30 Jun 2016 20:07:40 -0400 From: Luis de Bethencourt To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, salah.triki@gmail.com, viro@zeniv.linux.org.uk, hannes@cmpxchg.org, vdavydov@virtuozzo.com, Luis de Bethencourt Subject: [PATCH 1/3] befs: avoid dereferencing dentry twice Date: Fri, 1 Jul 2016 01:07:30 +0100 Message-Id: <1467331652-850-1-git-send-email-luisbg@osg.samsung.com> X-Mailer: git-send-email 2.5.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No need to dereference dentry twice to get the name when we already have it stored in a local variable. Signed-off-by: Luis de Bethencourt --- Hi, 3 more things I noticed while familiarizing myself with the code of this filesystem. Enjoying very much learning how it works. Thanks, Luis fs/befs/linuxvfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 619b998..6740b0d 100644 --- a/fs/befs/linuxvfs.c +++ b/fs/befs/linuxvfs.c @@ -179,7 +179,7 @@ befs_lookup(struct inode *dir, struct dentry *dentry, unsigned int flags) kfree(utfname); } else { - ret = befs_btree_find(sb, ds, dentry->d_name.name, &offset); + ret = befs_btree_find(sb, ds, name, &offset); } if (ret == BEFS_BT_NOT_FOUND) { -- 2.5.1