From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932483AbcGDCzG (ORCPT ); Sun, 3 Jul 2016 22:55:06 -0400 Received: from mail-co1nam03on0065.outbound.protection.outlook.com ([104.47.40.65]:27552 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932249AbcGDCzD (ORCPT ); Sun, 3 Jul 2016 22:55:03 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; samsung.com; dkim=none (message not signed) header.d=none;samsung.com; dmarc=fail action=none header.from=nxp.com; From: Peter Chen To: , CC: , , , , "Peter Chen" , Chanwoo Choi , Kukjin Kim , Krzysztof Kozlowski Subject: [PATCH v2 1/1] devfreq: exynos-bus: add missing of_node_put after calling of_parse_phandle Date: Mon, 4 Jul 2016 10:47:46 +0800 Message-ID: <1467600466-13667-1-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Matching-Connectors: 131120744978469721;(91ab9b29-cfa4-454e-5278-08d120cd25b8);() X-Forefront-Antispam-Report: CIP:192.88.168.50;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(189002)(199003)(8666005)(356003)(229853001)(68736007)(8676002)(92566002)(2906002)(85426001)(81156014)(4326007)(81166006)(106466001)(105606002)(586003)(5001770100001)(19580405001)(19580395003)(97736004)(47776003)(6806005)(86362001)(305945005)(87936001)(189998001)(50466002)(7846002)(50986999)(33646002)(48376002)(575784001)(104016004)(77096005)(5003940100001)(8936002)(50226002)(36756003)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:BLUPR03MB582;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD024;1:hXN13HBaRDnRo7u3WB6xYQ5S77ji65bcu6b5MsDvx0vcon/r485/BQyHpani1kwGx+oT65cdBtDrpuABFIIGMiwCs90o+T4nB2WxPDFajCCHQD59BcwSCLhTeJqXB4wigioGOq4/QSvhJavPgy0PiOCWufyEgsbfjEP4davdT6cVUJ2qW8gUuGKyNsKEdN2KLm9WoxImhVFJGO7wh358xnkeBOSva+67E7bYlA4awZ/XkYdKRhDkBe2KaYtD8LZfrDUN3v+qWOlIqYYOYYOr12TH0eiwTa2SQHl46EmuSivSiTLdnwJxHaC4Mxk399XL8DI983SLGY8BJ/hMGHXNabt4NkvE6/xYumu+S+3vJet/l4ZfcmMdf693khpqT9BAhqp/IoaZeNSPbd879mbmL5Bam/l/DgZV2qVU79/gl3Fcqk66RnyIKjpQL7zNrNBDc5KAglih94OUXFE59LVR4sw9AUbC6GCSM1OEToZTtUrIIxLIs+NOQtFYRXAncbyIAXgSsOwFpGy9irW1sYAmeqYmvjdo2qnubokUav1L8jynh1pfZxJUp178hQxBnAEgEgRh1ncy1M4rfOxDX6TPKw== MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: f192082f-e533-46cc-f1f8-08d3a3b69594 X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB582;2:iO0oo5UuzH+54lB7umotaj0XQFN2Vt+8394KY+vK1ddeOZIxZj722TN8jzbYOw8JwcBPvaWYrxa0LbTvQeAGU+sDoqEeMRF+86pf1H5DCwRVTio89PEAX0hjemU7c20S8Z4mO1JxNK4Qn/QkiYmIzvlFYfTywyM1w7V2croTQV+kOyxvX5jPdHw4lgi1GH5d;3:ZUSvFt6s7yje+yW31dT2T9rbTgr0kP8E+N0IqTDyMMSl6Q/VFHE60y4NrKQuntqUJY8Rj4ciqHxCJZXawDFIsGHAe3nHojLaKFlpt3Aijp3pL8SwnDb5E6nCOadmRu4msGdFajsKsp00pqEHLGGyx22pUUgYTkFYBa6eLJYXbjjp46A8jGNr6SROQxF5Lv60P8uoAI/uoolOeGNKpUeuF6mhVMedvL6EuFAHWbFeics= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB582; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB582;25:PWib366U1vPw4rWjZTTqQWFuiIEl7MD5whHsdKlgT5wDSBMKjYlCPVrOYdrtGeNx3GmUslZZV9KYi6c64GxfRzTdm+ZpxDQ8HRgJgdFXkbCrFs5Kn9vmIxQ0DhIR6Uv0rPz2I8saW4m9hdWY8uq1sPH/UoP0c8q5NLn7xGAAcF7ET4F6o/AGGQONK4XKxZbU8XiHtYzM6pYGzLIUQXk6kOXKBMyieqC3boQ1loYILQh5EDpLoZCm3OGdsBBorsypODCU2phfUOPbJb5DbeN9ajPpRNo6XkAIIF3830FSIkk8jsh8UZG7wgsvB7Szy2YjNQkl2VkDiDpbzhnK4PDiRC7YOY2HpUmA0M7CCZ6g1dZV2ES7/MAhuEycOcdPQpme33BycoXriqA4p+h3b+I71VGVV7PD4FPBaX+S0WbnSu5y6LyYHYslHv3fh0r6KOJFQ2rTa1ugeLSObC86JyTg6m0rEdQTpPxxr6/aVvirHgJnodhXX9uAXezzmabpd/MXB7ndOlSjrpoK4qp9McB/5EazOxFbDH1oiXbHMUd/MmzHgfOUFEC6Y2zgeB69QybkTqygQqOlIWS0g9A0JqjhCz8KICqKjM+QE8vrHd9izTNRffpNJXvz4IcizyGyM7KSSy5Co+4UpT0ekRxt/Lm8YatrYNmEErqaMt7HhIHkUdH3KhguBKt7A+eLjpSrdB222cpNtZsXcq+fFdz2jaxMUQ==;31:fC83lfq8wZmOj2vngfYkcwYfnCPUoDsQ8dfmLK510hN+jx0nC/iKHRfq0rnJKWGo1RBTyEUzfimP/viTYH/itbvxjg0cp3eh9M8Cnku+8Yz0TyuwGc32U8h+CHSSac9wLY7VbBuHnAGWm4bAlQpDGqwwBdVOmeU92e2xZ85GxVuzm8XFPgv6aXgsFuJf9zOQBQrCYFclDEt3Z5orelIBYQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(185117386973197)(7411616537696); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13015025)(13018025)(5005006)(8121501046)(13024025)(13023025)(13017025)(3002001)(10201501046)(6055026);SRVR:BLUPR03MB582;BCL:0;PCL:0;RULEID:(400006);SRVR:BLUPR03MB582; X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB582;4:b77CgfIRMTdhAUSPDEdjaskTLmcI0nSCaalc6TsFG7duVeiGt6w9f5iFGtQ8diE+aNvmuQGrw3Vs4li85ulPmY2kQHJLGlNx4GCjrqdWNyB1k31QoeOqm6VXDUBe4WD0exkQwxYQl/DsbNu7dnLGizg1Tlblxb1/vcQTi/Bsbo+WGBNp4PKSWRvasyGW4/cAzQXorpsqGB3fVsA3Co5DPtSEtxOMimVOB6KaxgZqh6Lyv9FlzqFTYZA+busvoOXykVobHQmJ/gXb2Qxk6KLzslnblViwS+mkPJHBp5rngLWwqq5OJ/LNjMGniTOoDwcsS1Z/R6feobiIxrRaFcnV1do1D66HCX8ogRWkWNUEShzF8stCWLKYuiqvI7xnYJbmRpkzPDYjM6G9GtkCi99eOe+F22U/uNVGzK+LFBlFEgRHRH9io9zJ//uxc4FbbuK+rZCaiIMR4DWDqc3mtk+uqG9JuYPLaH/MFJJbfZDNYzYbGGHHl2kcEkj6IPe+o3d5MAxYldmdkIaXBsaLAumJktwPl4YdUwXETypN1fQbvMsj9tb/+EdNPYevncVbigJhZC9Wum/2k3hWQX8MhD5pjQ== X-Forefront-PRVS: 0993689CD1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BLUPR03MB582;23:dujOSxHbMnr6X8Byko0heQl+a45C965iT5MuYtjHwD?= =?us-ascii?Q?5/s4qsf7RUFLh2e9cgsjuNtlVJk2cJ+cGdXWkHtFBHMjyOiJSIaqghh4yYDj?= =?us-ascii?Q?MH9xcRGbM9rzUonlgImVbsYDFWUa+RPYMXDT5z21odCOBmJ+Z09qNmbjryuQ?= =?us-ascii?Q?runpN7VeThIU8e6oCNg9JGVNGvT9LMk4OGn/WPjNfmz5EmVBY/gTNS7cwRvq?= =?us-ascii?Q?G2KwZkuNJbDvcMwPjLq4CYCseTp2WvMMMsu517Ltt4qJG/t8VY4L0bKCVv4+?= =?us-ascii?Q?Y6wuhNTD457Jp+ZE7qMZzBF4aJckG6HwkNP6MkIvWIVUlICoroso7GyDMml7?= =?us-ascii?Q?7UZZPTFqRJzUYi9pVI7/ri6R0IME9XyT5VPq6JXVbh1zkVeq3WfYinf146s0?= =?us-ascii?Q?eP1o1X3PGuKneWszOgav9m1mRdu/zsVO5Yqooqh23iTWSlDWrTW21apwV2aP?= =?us-ascii?Q?SGGMkb9Kjsbt4/T96bk0fULUNMIScxl9QECrNl3ZOMY1skX6XDzk7PITizXG?= =?us-ascii?Q?Ty4YvCM+L3VAE54jwB7/AaBZ9uSaXDaI2G2A/GUTDh0YWHt54zdkhOW5Spd8?= =?us-ascii?Q?38oYHRKf5o9eD1EMcwaBCaKU/St6tIscOChM4Q803tJRJ71gyzRD1oyxpSey?= =?us-ascii?Q?Gv6eAFWqF6+2LUB+h9VuGzouuE77eFFSqnNsb2rtokkgNUP6LFi7bFx3cK0M?= =?us-ascii?Q?ekoZchpHtOp4nS2TCiIpeh0S7VcHOnpexSdtSxmB2zJW1ptBM3ncbuU1scR5?= =?us-ascii?Q?dny0R/VBzE09ZZ2uZgcooktb66scgAhIOY69YpT8c72CkOsbxn51ijxaWnAw?= =?us-ascii?Q?ffHOIgUj80RSpehpOPJBn3k+05CWsVUcURUsm7yY/pCXj1Cm4MURw+Izm8QG?= =?us-ascii?Q?+tWdlJL+yy3OoJ8ASSS4N3O1fQDjcs5fjSJOEERkX3W1/L1zu07DQmF3qCHJ?= =?us-ascii?Q?X237idAXSRAcJZVvtWGElH0m8wnBVfv/ZWjN02dKwf49bf2b63XsTUeGTh8O?= =?us-ascii?Q?qcDsM9bLCpc4Jh/IhKRbnIemAwuTR1I+WB5fRz5aaUguQVVumr4W6hok8TzF?= =?us-ascii?Q?WS72CKHsdX3A1XscKJ04e40t4lARXREA42LIXxeAIfK4a/vA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BLUPR03MB582;6:PAXiMZzAAEa4HCfDTBDEvgYSnL08cjjRH533fvKrUC1ho0fno65VYcLWGkKEnIqCHq01LocqUAYiZoEPuOdFYa/EmOqY6yaqPT8G/3PxKP3n4wMRsPIhR6NyRaFFtts+6xsOjg0LOyW9Nxr0Ww6Yj/sjiW27ziPCBFXYw5Yk9GN8orhV+W2ddPI2zHs2mkcgODbSIYyWagVUfg6krqXvM0nLDs/Cp9SdOluDzlzOlOLG0aRsQwpxQheNhfOwwJJ/J36dElK0JUsskh9kttxD/9SZbssjCXnCSPPdGqvBG4o=;5:86nJOt7l3rrgA9s6uIBKo7AxW2M1bC8WaF775coXgawTGYXuhTsN7VnYsPv/crZtiZ0AFV39t3AMZ+Pvn0No7mq/17R3flbmUm53cr8rO7TMzucN9c/o3Sq8ny6XIrvR1La5ECWW4pzuyTVL9b1wK2KqgXvJD129+dFrEJuwwJI=;24:iPxviGn3AgGEOHCaEgYQbuyc8hazFmMmnmT/ateIS/2HTQRWRcE8zHkqXv5EVIWLKXeYNq3I5R97WfIrkWLqvVXRSyy5xH25PEdyY6k5XTo=;7:yDKMlWrK06uXt2N63VXsChYH0Fbr3v2MA3vc66IdRLjQcGAvMcl8gg+zgYu8uLTe5woCTafeT1DlN8kMOq8Xa20sxBxyQnew6QLtgJFmqTbkWOmKnRIospOkgnLZX9peLeCHDSKKzTc3F50v7wykea/Q9lRfe/8+yd3G2U3woy1SE2GpL/z3V24Gi3tMzOcV2cMu4Hz85pJMM8n8KOT+U5pcHkC9XrcXYMw8TNa2pZPHBQ7gTNAPLcIlG7tDgSE3 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2016 02:54:57.6597 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB582 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Cc: Chanwoo Choi Cc: MyungJoo Ham Cc: Kyungmin Park Cc: Kukjin Kim Cc: Krzysztof Kozlowski Signed-off-by: Peter Chen --- Changes at v2: - It should define node as pointer, kbuild test robot reports it drivers/devfreq/exynos-bus.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/devfreq/exynos-bus.c b/drivers/devfreq/exynos-bus.c index 2363d0a..4b4c63c 100644 --- a/drivers/devfreq/exynos-bus.c +++ b/drivers/devfreq/exynos-bus.c @@ -383,7 +383,7 @@ err_clk: static int exynos_bus_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct device_node *np = dev->of_node; + struct device_node *node, *np = dev->of_node; struct devfreq_dev_profile *profile; struct devfreq_simple_ondemand_data *ondemand_data; struct devfreq_passive_data *passive_data; @@ -415,10 +415,13 @@ static int exynos_bus_probe(struct platform_device *pdev) goto err; } - if (of_parse_phandle(dev->of_node, "devfreq", 0)) + node = of_parse_phandle(dev->of_node, "devfreq", 0); + if (node) { + of_node_put(node); goto passive; - else + } else { ret = exynos_bus_parent_parse_of(np, bus); + } if (ret < 0) goto err; -- 1.9.1