From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753447AbcGDLDo (ORCPT ); Mon, 4 Jul 2016 07:03:44 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:51726 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753025AbcGDLDn (ORCPT ); Mon, 4 Jul 2016 07:03:43 -0400 X-AuditID: cbfee68d-f79876d000001436-50-577a428cbf7a From: Alim Akhtar To: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Cc: alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com, javier@osg.samsung.com, pankaj.dubey@samsung.com, alim.akhtar@samsung.com Subject: [RFC PATCH 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock Date: Mon, 04 Jul 2016 16:33:13 +0530 Message-id: <1467630195-6929-1-git-send-email-alim.akhtar@samsung.com> X-Mailer: git-send-email 1.7.10.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPLMWRmVeSWpSXmKPExsVy+t8zfd1ep6pwg9exFh3XFjNZPJi3jc3i zds1TBavXxhaXN41h81i0dYv7Bb7OzsYHdg9nmy6yOixZ+JJNo8t/XfZPfq2rGL0+LxJLoA1 issmJTUnsyy1SN8ugStjyZNOtoJvLBWHlh1kbmBsZeli5OSQEDCRuLboKhOELSZx4d56ti5G Lg4hgZWMEnter2KEKVoy4xMjRGIWo8S9G8fAEkICPxklDs7kBbHZBLQl7k7fAjZJRMBGYuWs flYQm1mgj1Fi/zYREFtYIE7i5IlnQJs5OFgEVCVm/dAHMXkF3CSa1yhCrFKU6H42AewGCYFm domWH6vAxrAICEh8m3wIrFVCQFZi0wFmiHpJiYMrbrBMYBRcwMiwilE0tSC5oDgpvchQrzgx t7g0L10vOT93EyMkXHt3MN4+YH2IUYCDUYmHlyGmMlyINbGsuDL3EKMp0IaJzFKiyfnAqMgr iTc0NjOyMDUxNTYytzRTEudVlPoZLCSQnliSmp2aWpBaFF9UmpNafIiRiYNTqoFx72Hv18Gv ZueszDW8cJAxRvOl78ZJb2YmlBh3/umq1rr/6nrG/S1bJwRvF97nE65lcDV7Yu1WTQUVleP+ W1QT9VasEHA4+0Z8X+31z1MOPGRp3WfYqHnzy+mZuyO2mzuG/FAPOznjvb34jnyJyN1aU832 WNcwlk/9FH2YP/gUc/aEtW93LN3Qq8RSnJFoqMVcVJwIAP3yIw5SAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42I5/e+xoG6PU1W4QesCS4uOa4uZLB7M28Zm 8ebtGiaL1y8MLS7vmsNmsWjrF3aL/Z0djA7sHk82XWT02DPxJJvHlv677B59W1YxenzeJBfA GtXAaJORmpiSWqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDdIaS QlliTilQKCCxuFhJ3w7ThNAQN10LmMYIXd+QILgeIwM0kLCOMWPJk062gm8sFYeWHWRuYGxl 6WLk5JAQMJFYMuMTI4QtJnHh3nq2LkYuDiGBWYwS924cA0sICfxklDg4kxfEZhPQlrg7fQsT iC0iYCOxclY/K4jNLNDHKLF/mwiILSwQJ3HyxDOgBRwcLAKqErN+6IOYvAJuEs1rFCFWKUp0 P5vANoGRewEjwypGidSC5ILipPRco7zUcr3ixNzi0rx0veT83E2M4Kh4Jr2D8fAu90OMAhyM Sjy8GvWV4UKsiWXFlbmHGCU4mJVEeNntqsKFeFMSK6tSi/Lji0pzUosPMZoCrZ/ILCWanA+M 2LySeENjEzMjSyMzCyMTc3Mlcd7H/9eFCQmkJ5akZqemFqQWwfQxcXBKNTAe4a+7rXrZ+7b6 njf218wUTNfrV5oHCmu/mdrN/eW15nlDkfI9dR8Dj/WvMX94Ls/yoopTXfOBPD2xv3PyW1aw i7v3/fo1+4l9g/ZOfceccg3LmifVSjnqBwvsX5yvP/5kqz+rq3PQHstdLztPNtsoJwnr5Ezn Pxv9/Fzcw20nRW+6hDkzb1RiKc5INNRiLipOBAAzLzCHoAIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At the end of s3c_rtc_probe(), s3c_rtc_disable_clk() being called with rtc clock already disabled, which looks extra and unnecessary call. Lets clean it up. Signed-off-by: Alim Akhtar --- drivers/rtc/rtc-s3c.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index d01ad7e..b083840 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -577,8 +577,6 @@ static int s3c_rtc_probe(struct platform_device *pdev) s3c_rtc_setfreq(info, 1); - s3c_rtc_disable_clk(info); - return 0; err_nortc: -- 1.7.10.4