From: Alim Akhtar <alim.akhtar@samsung.com>
To: rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Cc: alexandre.belloni@free-electrons.com, k.kozlowski@samsung.com,
javier@osg.samsung.com, pankaj.dubey@samsung.com,
alim.akhtar@samsung.com
Subject: [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq()
Date: Mon, 04 Jul 2016 16:33:14 +0530 [thread overview]
Message-ID: <1467630195-6929-2-git-send-email-alim.akhtar@samsung.com> (raw)
In-Reply-To: <1467630195-6929-1-git-send-email-alim.akhtar@samsung.com>
As per code flow it is possible that s3c_rtc_setfreq() might get called
with rtc clock disabled and in set_freq we perform h/w registers read/write,
which might results in a kernel crash while probing rtc driver.
Below is one such case:
s3c_rtc_probe()
clk_prepare_enable(info->rtc_clk) // rtc clock enabled
s3c_rtc_gettime() // will enable clk if not done, and disable it upon exit
s3c_rtc_setfreq() //then this will be called with clk disabled
This patch take cares of such issue by adding s3c_rtc_{enable/disable}_clk in
s3c_rtc_setfreq().
Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
---
drivers/rtc/rtc-s3c.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index b083840..1168814 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -149,12 +149,14 @@ static int s3c_rtc_setfreq(struct s3c_rtc *info, int freq)
if (!is_power_of_2(freq))
return -EINVAL;
+ s3c_rtc_enable_clk(info);
spin_lock_irq(&info->pie_lock);
if (info->data->set_freq)
info->data->set_freq(info, freq);
spin_unlock_irq(&info->pie_lock);
+ s3c_rtc_disable_clk(info);
return 0;
}
--
1.7.10.4
next prev parent reply other threads:[~2016-07-04 11:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 11:03 [RFC PATCH 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock Alim Akhtar
2016-07-04 11:03 ` Alim Akhtar [this message]
2016-07-05 8:16 ` [RFC PATCH 2/2] rtc: s3c: Add s3c_rtc_{enable/disable}_clk in s3c_rtc_setfreq() Krzysztof Kozlowski
2016-07-05 8:52 ` Alim Akhtar
2016-07-05 8:56 ` Krzysztof Kozlowski
2016-07-05 9:43 ` pankaj.dubey
2016-07-05 9:44 ` pankaj.dubey
2016-07-05 7:18 ` [RFC PATCH 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock Krzysztof Kozlowski
2016-07-05 8:46 ` Alim Akhtar
2016-07-05 8:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467630195-6929-2-git-send-email-alim.akhtar@samsung.com \
--to=alim.akhtar@samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®