From: Gustavo Padovan <gustavo@padovan.org>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org,
Daniel Stone <daniels@collabora.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Rob Clark <robdclark@gmail.com>,
Greg Hackmann <ghackmann@google.com>,
John Harrison <John.C.Harrison@Intel.com>,
laurent.pinchart@ideasonboard.com, seanpaul@google.com,
marcheu@google.com, m.chehab@samsung.com,
Sumit Semwal <sumit.semwal@linaro.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: [PATCH v3 0/4] dma-buf/sync_file: rework fences on struct sync_file
Date: Mon, 4 Jul 2016 20:57:04 -0300 [thread overview]
Message-ID: <1467676628-4121-1-git-send-email-gustavo@padovan.org> (raw)
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Hi all,
This patchset improves fence support on Sync File. The basic idea
is to have only sync_file->fence and store all fences there, either as
normal fences or fence_arrays. That way we can remove some potential
duplication when using fence_array with sync_file: the duplication of the array
of fences and the duplication of fence_add_callback() for all fences.
Now when creating a new sync_file during the merge process sync_file_set_fence()
will set sync_file->fence based on the number of fences for that sync_file. If
there is more than one fence a fence_array is created. One important advantage
approach is that we only add one fence callback now, no matter how many fences
there are in a sync_file - the individual callbacks are added by fence_array.
This patchset also adds sync_file_get_fence() to retrieve fence from a sync_file
file descriptor.
Please review! Thanks!
Gustavo
---
Changes sunce PATCH v2 (Coments from Chris Wilson)
- fix checkpatch warnings
- use fence_get() to set the fence directly
Changes since PATCH v1 (Comments from Chris Wilson)
- use sizeof(*fence) to reallocate array
- fix typo in comments
- protect num_fences sum against overflows
- use array->base instead of casting the to struct fence
- remove ternary if from ops comparison in fence_is_array()
- add EXPORT_SYMBOL(fence_array_ops)
Changes since RFC v2 (Comments from Chris Wilson and Christian König):
- struct sync_file lost status member in favor of fence_is_signaled()
- drop use of fence_array_teardown()
- use sizeof(*fence) to allocate only an array on fence pointers
Changes since RFC v1 (Comments from Chris Wilson and Christian König):
- Not using fence_ops anymore.
- fence_is_array() was created to differentiate fence from fence_array
- fence_array_teardown() is now exported and used under fence_is_array()
- struct sync_file lost num_fences member
Gustavo Padovan (4):
dma-buf/fence-array: add fence_is_array()
dma-buf/sync_file: rework fence storage in struct file
dma-buf/sync_file: add sync_file_get_fence()
Documentation: add doc for sync_file_get_fence()
Gustavo Padovan (4):
dma-buf/fence-array: add fence_is_array()
dma-buf/sync_file: rework fence storage in struct file
dma-buf/sync_file: add sync_file_get_fence()
Documentation: add doc for sync_file_get_fence()
Documentation/sync_file.txt | 15 +++
drivers/dma-buf/fence-array.c | 1 +
drivers/dma-buf/sync_file.c | 192 ++++++++++++++++++++++++-----------
drivers/staging/android/sync_debug.c | 12 ++-
include/linux/fence-array.h | 10 ++
include/linux/sync_file.h | 18 ++--
6 files changed, 174 insertions(+), 74 deletions(-)
--
2.5.5
next reply other threads:[~2016-07-04 23:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 23:57 Gustavo Padovan [this message]
2016-07-04 23:57 ` [PATCH v3 1/4] dma-buf/fence-array: add fence_is_array() Gustavo Padovan
2016-07-05 12:26 ` Christian König
2016-07-04 23:57 ` [PATCH v3 2/4] dma-buf/sync_file: rework fence storage in struct file Gustavo Padovan
2016-07-04 23:57 ` [PATCH v3 3/4] dma-buf/sync_file: add sync_file_get_fence() Gustavo Padovan
2016-07-04 23:57 ` [PATCH v3 4/4] Documentation: add doc for sync_file_get_fence() Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467676628-4121-1-git-send-email-gustavo@padovan.org \
--to=gustavo@padovan.org \
--cc=John.C.Harrison@Intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ghackmann@google.com \
--cc=gustavo.padovan@collabora.co.uk \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcheu@google.com \
--cc=robdclark@gmail.com \
--cc=seanpaul@google.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®