From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754759AbcGEKSF (ORCPT ); Tue, 5 Jul 2016 06:18:05 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:52969 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754728AbcGEKR7 (ORCPT ); Tue, 5 Jul 2016 06:17:59 -0400 From: Philipp Zabel To: linux-kernel@vger.kernel.org Cc: Maxime Ripard , Chen-Yu Tsai , Steffen Trumtrar , Dinh Nguyen , linux-arm-kernel@lists.infradead.org, Philipp Zabel Subject: [PATCH 2/3] reset: sunxi: use readl/writel_relaxed Date: Tue, 5 Jul 2016 12:17:51 +0200 Message-Id: <1467713872-4051-2-git-send-email-p.zabel@pengutronix.de> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1467713872-4051-1-git-send-email-p.zabel@pengutronix.de> References: <1467713872-4051-1-git-send-email-p.zabel@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This just removes the rmb()/wmb() pair between register read and write. Since no relevant reads follow the rmb and no relevant writes precede the wmb, they should be safe to remove. Signed-off-by: Philipp Zabel --- drivers/reset/reset-sunxi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/reset/reset-sunxi.c b/drivers/reset/reset-sunxi.c index 3080190..7a35950 100644 --- a/drivers/reset/reset-sunxi.c +++ b/drivers/reset/reset-sunxi.c @@ -41,8 +41,8 @@ static int sunxi_reset_assert(struct reset_controller_dev *rcdev, spin_lock_irqsave(&data->lock, flags); - reg = readl(data->membase + (bank * 4)); - writel(reg & ~BIT(offset), data->membase + (bank * 4)); + reg = readl_relaxed(data->membase + (bank * 4)); + writel_relaxed(reg & ~BIT(offset), data->membase + (bank * 4)); spin_unlock_irqrestore(&data->lock, flags); @@ -62,8 +62,8 @@ static int sunxi_reset_deassert(struct reset_controller_dev *rcdev, spin_lock_irqsave(&data->lock, flags); - reg = readl(data->membase + (bank * 4)); - writel(reg | BIT(offset), data->membase + (bank * 4)); + reg = readl_relaxed(data->membase + (bank * 4)); + writel_relaxed(reg | BIT(offset), data->membase + (bank * 4)); spin_unlock_irqrestore(&data->lock, flags); -- 2.8.1