From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932744AbcGFXkg (ORCPT ); Wed, 6 Jul 2016 19:40:36 -0400 Received: from p3plsmtps2ded01.prod.phx3.secureserver.net ([208.109.80.58]:48612 "EHLO p3plsmtps2ded01.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755651AbcGFXkf (ORCPT ); Wed, 6 Jul 2016 19:40:35 -0400 x-originating-ip: 72.167.245.219 From: kys@exchange.microsoft.com To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com Cc: "K. Y. Srinivasan" Subject: [PATCH 1/1] Tools: hv: kvp: ensure kvp device fd is closed on exec Date: Wed, 6 Jul 2016 18:24:10 -0700 Message-Id: <1467854650-9554-1-git-send-email-kys@exchange.microsoft.com> X-Mailer: git-send-email 1.7.4.1 Reply-To: kys@microsoft.com X-CMAE-Envelope: MS4wfDSzjKBV3GYJQhYyFmVB/9ndk5s1w6/B1YpU7ZNAVrXfzxhE1TzwX7hdhiUJM8niVoTR0IQwS47jiTHvJYogtwUeBT8hhftp1YwOS/jygofAKD5QtzO/ LyRbjGDwWyrrZU09CGJRqopHUTwdyn0i84R2a+xooXv5BR12642cGtsMxhzp/kM9TasrXwzavgrAPAw+TjwU+qGfG4MyXP8c67vgGMeO2Uz2FaTewt6v5pS+ xUyw7NhEjWADr67Heb0f1IL5FvfuTKmBTjhSQvKzZXXou/QXJo8TQlpMJMOvWJeiF8z54wDKH9zT9ldiDtyin0NNK9yh+gQlGGv4zd1BrVhd+8fgN6NclaCZ Gus+lbNZotpVJr4YIMdzwSei/rxU2+k8oQcMnQmigEUZu3MLfxyqUHeozk7lJb5UnwRkOn79qnta6uvtN+sEBnsO45uwBXOZ5a0IrOPKVC9rzVjS82s= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vitaly Kuznetsov KVP daemon does fork()/exec() (with popen()) so we need to close our fds to avoid sharing them with child processes. The immediate implication of not doing so I see is SELinux complaining about 'ip' trying to access '/dev/vmbus/hv_kvp'. Signed-off-by: Vitaly Kuznetsov Signed-off-by: K. Y. Srinivasan --- tools/hv/hv_kvp_daemon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c index 0d9f48e..bc7adb8 100644 --- a/tools/hv/hv_kvp_daemon.c +++ b/tools/hv/hv_kvp_daemon.c @@ -1433,7 +1433,7 @@ int main(int argc, char *argv[]) openlog("KVP", 0, LOG_USER); syslog(LOG_INFO, "KVP starting; pid is:%d", getpid()); - kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR); + kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR | O_CLOEXEC); if (kvp_fd < 0) { syslog(LOG_ERR, "open /dev/vmbus/hv_kvp failed; error: %d %s", -- 1.7.4.1