mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Matias Bjørling" <m@bjorling.me>
To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@fb.com
Cc: "Matias Bjørling" <m@bjorling.me>
Subject: [PATCH 11/17] lightnvm: remove nested lock conflict with mm
Date: Thu,  7 Jul 2016 09:54:17 +0200	[thread overview]
Message-ID: <1467878063-22919-12-git-send-email-m@bjorling.me> (raw)
In-Reply-To: <1467878063-22919-1-git-send-email-m@bjorling.me>

If a media manager tries to initialize it targets upon media manager
initialization, the media manager will need to know which target types
are available in LightNVM. The lists of which managers and target types
are available shares the same lock.

Therefore, on initialization, the nvm_lock is taken by LightNVM core,
which later leads to a deadlock when target types are enumerated by the
media manager.

Add an exclusive lock for target types to resolve this conflict.

Signed-off-by: Matias Bjørling <m@bjorling.me>
---
 drivers/lightnvm/core.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index 8afb04c..04469e0 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -28,6 +28,7 @@
 #include <linux/sched/sysctl.h>
 
 static LIST_HEAD(nvm_tgt_types);
+static DECLARE_RWSEM(nvm_tgtt_lock);
 static LIST_HEAD(nvm_mgrs);
 static LIST_HEAD(nvm_devices);
 static DECLARE_RWSEM(nvm_lock);
@@ -37,7 +38,7 @@ struct nvm_tgt_type *nvm_find_target_type(const char *name, int lock)
 	struct nvm_tgt_type *tmp, *tt = NULL;
 
 	if (lock)
-		down_write(&nvm_lock);
+		down_write(&nvm_tgtt_lock);
 
 	list_for_each_entry(tmp, &nvm_tgt_types, list)
 		if (!strcmp(name, tmp->name)) {
@@ -46,7 +47,7 @@ struct nvm_tgt_type *nvm_find_target_type(const char *name, int lock)
 		}
 
 	if (lock)
-		up_write(&nvm_lock);
+		up_write(&nvm_tgtt_lock);
 	return tt;
 }
 EXPORT_SYMBOL(nvm_find_target_type);
@@ -55,12 +56,12 @@ int nvm_register_tgt_type(struct nvm_tgt_type *tt)
 {
 	int ret = 0;
 
-	down_write(&nvm_lock);
+	down_write(&nvm_tgtt_lock);
 	if (nvm_find_target_type(tt->name, 0))
 		ret = -EEXIST;
 	else
 		list_add(&tt->list, &nvm_tgt_types);
-	up_write(&nvm_lock);
+	up_write(&nvm_tgtt_lock);
 
 	return ret;
 }
-- 
2.1.4

  parent reply	other threads:[~2016-07-07  7:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07  7:54 [GIT PULL 00/17] LightNVM pull request for 4.8 Matias Bjørling
2016-07-07  7:54 ` [PATCH 01/17] lightnvm: break the loop when rqd is not null Matias Bjørling
2016-07-07  7:54 ` [PATCH 02/17] lightnvm: add media manager mark_blk helper Matias Bjørling
2016-07-07  7:54 ` [PATCH 03/17] lightnvm: initialize ppa_addr in dev_to_generic_addr() Matias Bjørling
2016-07-07  7:54 ` [PATCH 04/17] nvme: lightnvm: make MLC num_pairs little endian Matias Bjørling
2016-07-07  7:54 ` [PATCH 05/17] lightnvm: Make functions not used by ouside static Matias Bjørling
2016-07-07  7:54 ` [PATCH 06/17] lightnvm: remove checkpatch warning for unsigned ints Matias Bjørling
2016-07-07  7:54 ` [PATCH 07/17] lightnvm: fix checkpatch terse errors Matias Bjørling
2016-07-07  7:54 ` [PATCH 08/17] lightnvm: remove open/close statistics for gennvm Matias Bjørling
2016-07-07  7:54 ` [PATCH 09/17] lightnvm: rename gennvm and update description Matias Bjørling
2016-07-07  7:54 ` [PATCH 10/17] lightnvm: move target mgmt into media mgr Matias Bjørling
2016-07-07  7:54 ` Matias Bjørling [this message]
2016-07-07  7:54 ` [PATCH 12/17] lightnvm: remove unused lists from struct rrpc_block Matias Bjørling
2016-07-07  7:54 ` [PATCH 13/17] lightnvm: remove _unlocked variant of [get/put]_blk Matias Bjørling
2016-07-07  7:54 ` [PATCH 14/17] lightnvm: make rrpc_map_page call nvm_get_blk outside locks Matias Bjørling
2016-07-07  7:54 ` [PATCH 15/17] lightnvm: fix lun offset calculation for mark blk Matias Bjørling
2016-07-07  7:54 ` [PATCH 16/17] lightnvm: make ppa_list const in nvm_set_rqd_list Matias Bjørling
2016-07-07  7:54 ` [PATCH 17/17] lightnvm: make __nvm_submit_ppa static Matias Bjørling
2016-07-07 14:52 ` [GIT PULL 00/17] LightNVM pull request for 4.8 Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467878063-22919-12-git-send-email-m@bjorling.me \
    --to=m@bjorling.me \
    --cc=axboe@fb.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®