From: Michael Neuling <mikey@neuling.org>
To: "Shreyas B. Prabhu" <shreyas@linux.vnet.ibm.com>, mpe@ellerman.id.au
Cc: benh@au1.ibm.com, paulus@ozlabs.org, ego@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
maddy@linux.vnet.ibm.com,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v7 09/11] cpuidle/powernv: cleanup powernv_add_idle_states
Date: Fri, 08 Jul 2016 12:42:35 +1000 [thread overview]
Message-ID: <1467945755.27479.160.camel@neuling.org> (raw)
In-Reply-To: <1467924432-29003-10-git-send-email-shreyas@linux.vnet.ibm.com>
> /*
> @@ -230,7 +238,7 @@ static int powernv_add_idle_states(void)
> strcpy(powernv_states[nr_idle_states].desc, "FastSleep");
> powernv_states[nr_idle_states].flags = CPUIDLE_FLAG_TIMER_STOP;
> powernv_states[nr_idle_states].target_residency = 300000;
> - powernv_states[nr_idle_states].enter = &fastsleep_loop;
> + powernv_states[nr_idle_states].enter = fastsleep_loop;
You can change this code too with the same thing.
static struct cpuidle_state powernv_states[CPUIDLE_STATE_MAX] = {
{ /* Snooze */
.name = "snooze",
.desc = "snooze",
.exit_latency = 0,
.target_residency = 0,
.enter = &snooze_loop },
};
Mikey
next prev parent reply other threads:[~2016-07-08 2:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 20:47 [PATCH v7 00/11] powerpc/powernv/cpuidle: Add support for POWER ISA v3 idle states Shreyas B. Prabhu
2016-07-07 20:47 ` [PATCH v7 01/11] powerpc/powernv: Use PNV_THREAD_WINKLE macro while requesting for winkle Shreyas B. Prabhu
2016-07-15 13:10 ` Balbir Singh
2016-07-07 20:47 ` [PATCH v7 02/11] powerpc/kvm: make hypervisor state restore a function Shreyas B. Prabhu
2016-07-07 20:47 ` [PATCH v7 03/11] powerpc/powernv: Rename idle_power7.S to idle_book3s.S Shreyas B. Prabhu
2016-07-07 20:47 ` [PATCH v7 04/11] powerpc/powernv: Rename reusable idle functions to hardware agnostic names Shreyas B. Prabhu
2016-07-07 20:47 ` [PATCH v7 05/11] powerpc/powernv: Make pnv_powersave_common more generic Shreyas B. Prabhu
2016-07-07 20:47 ` [PATCH v7 06/11] powerpc/powernv: abstraction for saving SPRs before entering deep idle states Shreyas B. Prabhu
2016-07-07 20:47 ` [PATCH v7 07/11] powerpc/powernv: Add platform support for stop instruction Shreyas B. Prabhu
2016-07-08 2:20 ` Michael Neuling
2016-07-08 4:19 ` Shreyas B Prabhu
2016-07-08 4:27 ` Michael Neuling
2016-07-07 20:47 ` [PATCH v7 08/11] cpuidle/powernv: Use CPUIDLE_STATE_MAX instead of MAX_POWERNV_IDLE_STATES Shreyas B. Prabhu
2016-07-07 20:47 ` [PATCH v7 09/11] cpuidle/powernv: cleanup powernv_add_idle_states Shreyas B. Prabhu
2016-07-08 2:42 ` Michael Neuling [this message]
2016-07-07 20:47 ` [PATCH v7 10/11] cpuidle/powernv: Add support for POWER ISA v3 idle states Shreyas B. Prabhu
2016-07-07 20:47 ` [PATCH v7 11/11] powerpc/powernv: Use deepest stop state when cpu is offlined Shreyas B. Prabhu
2016-07-08 2:49 ` [PATCH v7 00/11] powerpc/powernv/cpuidle: Add support for POWER ISA v3 idle states Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467945755.27479.160.camel@neuling.org \
--to=mikey@neuling.org \
--cc=benh@au1.ibm.com \
--cc=daniel.lezcano@linaro.org \
--cc=ego@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
--cc=rafael.j.wysocki@intel.com \
--cc=shreyas@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome