From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754567AbcGHKSZ (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jul 2016 06:18:25 -0400
Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:45149 "EHLO
	metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1754112AbcGHKST convert rfc822-to-8bit
	(ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jul 2016 06:18:19 -0400
Message-ID: <1467973066.2472.238.camel@pengutronix.de>
Subject: Re: [PATCH v9 1/4] dt-bindings: soc: Add documentation for the
 MediaTek GCE unit
From: Jan =?ISO-8859-1?Q?L=FCbbe?= <jlu@pengutronix.de>
To: HS Liao <hs.liao@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Daniel Kurtz <djkurtz@chromium.org>,
        Monica Wang <monica.wang@mediatek.com>,
        Jiaguang Zhang <jiaguang.zhang@mediatek.com>,
        Nicolas Boichat <drinkcat@chromium.org>,
        cawa cheng <cawa.cheng@mediatek.com>,
        Bibby Hsieh <bibby.hsieh@mediatek.com>, YT Shen <yt.shen@mediatek.com>,
        Damon Chu <damon.chu@mediatek.com>, devicetree@vger.kernel.org,
        Sascha Hauer <kernel@pengutronix.de>,
        Daoyuan Huang <daoyuan.huang@mediatek.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Glory Hung <glory.hung@mediatek.com>, CK HU <ck.hu@mediatek.com>,
        linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, srv_heupstream@mediatek.com,
        Josh-YC Liu <josh-yc.liu@mediatek.com>, linux-kernel@vger.kernel.org,
        Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
        Philipp Zabel <p.zabel@pengutronix.de>
Date: Fri, 08 Jul 2016 12:17:46 +0200
In-Reply-To: <1467270883-1407-2-git-send-email-hs.liao@mediatek.com>
References: <1467270883-1407-1-git-send-email-hs.liao@mediatek.com>
	 <1467270883-1407-2-git-send-email-hs.liao@mediatek.com>
Organization: Pengutronix
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
X-Mailer: Evolution 3.12.9-1+b1 
Mime-Version: 1.0
X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c3
X-SA-Exim-Mail-From: jlu@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Do, 2016-06-30 at 15:14 +0800, HS Liao wrote:
[...]
> +Required properties:
> +- compatible: Must be "mediatek,mt8173-gce"
> +- reg: Address range of the GCE unit
> +- interrupts: The interrupt signal from the GCE block
> +- clock: Clocks according to the common clock binding
> +- clock-names: Must be "gce" to stand for GCE clock
> +- #mbox-cells: Should be 1
[...]
> +		#mbox-cells = <1>;
[...]
> +		mediatek,gce = <&gce>;
> +		mboxes = <&gce 0 1 /* main display with merging wfe */
> +			  &gce 1 1>; /* sub display with merging wfe */

It seems that you use two cells instead of one as you declared above.
This should be consistent.

Also, why do you need an explicit phandle to the gce if you already use
mailboxes?

Best regards,
Jan Lübbe
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |