From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932787AbcGHRfH (ORCPT ); Fri, 8 Jul 2016 13:35:07 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:37294 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755520AbcGHRe5 (ORCPT ); Fri, 8 Jul 2016 13:34:57 -0400 Message-ID: <1467999258.2365.71.camel@pengutronix.de> Subject: Re: [PATCH 12/16] gpu: ipu-v3: Fix CSI0 blur in NTSC format From: Philipp Zabel To: Steve Longerbeam Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Suresh Dhandapani Date: Fri, 08 Jul 2016 19:34:18 +0200 In-Reply-To: <1467932621-358-13-git-send-email-steve_longerbeam@mentor.com> References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-13-git-send-email-steve_longerbeam@mentor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: > From: Suresh Dhandapani > > This patch will change the register IPU_CSI0_CCIR_CODE_2 value from > 0x40596 to 0x405A6. The change is related to the Start of field 1 > first blanking line command bit[5-3] for NTSC format only. This > change is dependent with ADV chip where the NEWAVMODE is set to 0 > in register 0x31. Setting NEWAVMODE to "0" in ADV means "EAV/SAV > codes generated to suit analog devices encoders". > > Signed-off-by: Suresh Dhandapani > --- > drivers/gpu/ipu-v3/ipu-csi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers/gpu/ipu-v3/ipu-csi.c > index 0eac28c..ec81958 100644 > --- a/drivers/gpu/ipu-v3/ipu-csi.c > +++ b/drivers/gpu/ipu-v3/ipu-csi.c > @@ -422,7 +422,7 @@ int ipu_csi_init_interface(struct ipu_csi *csi, > > ipu_csi_write(csi, 0xD07DF | CSI_CCIR_ERR_DET_EN, > CSI_CCIR_CODE_1); > - ipu_csi_write(csi, 0x40596, CSI_CCIR_CODE_2); > + ipu_csi_write(csi, 0x405A6, CSI_CCIR_CODE_2); > ipu_csi_write(csi, 0xFF0000, CSI_CCIR_CODE_3); > } else { > dev_err(csi->ipu->dev, This looks like a very hardware specific hack? I'll at least have to test if that also works with other analog decoders. regards Philipp