From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932824AbcGHRfM (ORCPT ); Fri, 8 Jul 2016 13:35:12 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:55644 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755664AbcGHRe5 (ORCPT ); Fri, 8 Jul 2016 13:34:57 -0400 Message-ID: <1467999275.2365.73.camel@pengutronix.de> Subject: Re: [PATCH 05/16] gpu: ipu-v3: Add IDMA channel linking support From: Philipp Zabel To: Steve Longerbeam Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Steve Longerbeam Date: Fri, 08 Jul 2016 19:34:35 +0200 In-Reply-To: <1467932621-358-6-git-send-email-steve_longerbeam@mentor.com> References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-6-git-send-email-steve_longerbeam@mentor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: > Adds functions to link and unlink IDMAC source channels to sink > channels. > > So far the following links are supported: > > IPUV3_CHANNEL_IC_PRP_ENC_MEM -> IPUV3_CHANNEL_MEM_ROT_ENC > PUV3_CHANNEL_IC_PRP_VF_MEM -> IPUV3_CHANNEL_MEM_ROT_VF > IPUV3_CHANNEL_IC_PP_MEM -> IPUV3_CHANNEL_MEM_ROT_PP > > More links can be added to the idmac_link_info[] array. > > Signed-off-by: Steve Longerbeam > --- > drivers/gpu/ipu-v3/ipu-common.c | 112 ++++++++++++++++++++++++++++++++++++++++ > include/video/imx-ipu-v3.h | 3 ++ > 2 files changed, 115 insertions(+) > > diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c > index 49af121..6d1676e 100644 > --- a/drivers/gpu/ipu-v3/ipu-common.c > +++ b/drivers/gpu/ipu-v3/ipu-common.c > @@ -730,6 +730,118 @@ void ipu_set_ic_src_mux(struct ipu_soc *ipu, int csi_id, bool vdi) > } > EXPORT_SYMBOL_GPL(ipu_set_ic_src_mux); > > + > +/* IDMAC Channel Linking */ > + > +struct idmac_link_reg_info { > + int chno; > + u32 reg; > + int shift; > + int bits; > + u32 sel; > +}; > + > +struct idmac_link_info { > + struct idmac_link_reg_info src; > + struct idmac_link_reg_info sink; > +}; > + > +static const struct idmac_link_info idmac_link_info[] = { > + { > + .src = { 20, IPU_FS_PROC_FLOW1, 0, 4, 7 }, > + .sink = { 45, IPU_FS_PROC_FLOW2, 0, 4, 1 }, Please use the defines here: IPUV3_CHANNEL_IC_PRP_ENC_MEM IPUV3_CHANNEL_MEM_ROT_ENC > + }, { > + .src = { 21, IPU_FS_PROC_FLOW1, 8, 4, 8 }, > + .sink = { 46, IPU_FS_PROC_FLOW2, 4, 4, 1 }, and so on. > + }, { > + .src = { 22, IPU_FS_PROC_FLOW1, 16, 4, 5 }, > + .sink = { 47, IPU_FS_PROC_FLOW2, 12, 4, 3 }, > + }, > +}; [...] regards Philipp