mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "jeffrey.lin" <yajohn@gmail.com>
To: dmitry.torokhov@gmail.com, rydberg@euromail.se,
	groeck@chromium.org, robh@kernel.org
Cc: jeffrey.lin@rad-ic.com, ealin.chiu@rad-ic.com,
	jason.yeh@rad-ic.com, KP.li@rad-ic.com,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re:[v1.1,1/3] driver: input :touchscreen : add Raydium crc touch function
Date: Sat,  9 Jul 2016 07:41:35 -0700	[thread overview]
Message-ID: <1468075295-44799-1-git-send-email-jeffrey.lin@rad-ic.com> (raw)
In-Reply-To: <1467909479-43471-1-git-send-email-jeffrey.lin@rad-ic.com>

Hi dmitry:
> >>  		input_mt_report_slot_state(ts->input, MT_TOOL_FINGER, state);
> >>  
> >> -		if (!state)
> >> -			continue;
> >> -
> >> -		input_report_abs(ts->input, ABS_MT_POSITION_X,
> >> +		if (state == 0x01) {
> 
> >Why we need this change? How is it related to CRC? Do you intent to
> >report contact as active but not emit any position data of state is
> >neither 0 nor 1?
> This is no relationship with CRC, just want to make sure report points as state equal to 1.

>If active contact only reported when state is 0x01 you need to update
>the statements above like this:
>
>	input_mt_report_slot_state(ts->input, MT_TOOL_FINGER,
>				   state == 0x01);
>
>	if (state != 0x01)
>		continue;
>
>but I am surprised that your firmware would report anything but 0 for
>inactive contact.
>
>Could you document all possible state values?

Actual, our firmware only can report touch points as 1. Other cases is nothing to do. Can I merge this
part you suggested into the CRC version patch?

Thanks.

Jeffrey

      parent reply	other threads:[~2016-07-09 14:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07 16:37 [PATCH] [v1.1 1/3] " jeffrey.lin
2016-07-07 17:12 ` Dmitry Torokhov
2016-07-08 14:36 ` jeffrey.lin
2016-07-08 18:56   ` [v1.1,1/3] " Dmitry Torokhov
2016-07-09 14:41 ` jeffrey.lin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468075295-44799-1-git-send-email-jeffrey.lin@rad-ic.com \
    --to=yajohn@gmail.com \
    --cc=KP.li@rad-ic.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=ealin.chiu@rad-ic.com \
    --cc=groeck@chromium.org \
    --cc=jason.yeh@rad-ic.com \
    --cc=jeffrey.lin@rad-ic.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rydberg@euromail.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®