From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756788AbcGIQfB (ORCPT ); Sat, 9 Jul 2016 12:35:01 -0400 Received: from out1134-226.mail.aliyun.com ([42.120.134.226]:58871 "EHLO out1134-226.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579AbcGIQfA (ORCPT ); Sat, 9 Jul 2016 12:35:00 -0400 X-Greylist: delayed 320 seconds by postgrey-1.27 at vger.kernel.org; Sat, 09 Jul 2016 12:34:59 EDT X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07660423|-1;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03283;MF=chengang@emindsoft.com.cn;NM=1;PH=DS;RN=12;RT=11;SR=0;TI=SMTPD_----5.m7EKw_1468081752; From: chengang@emindsoft.com.cn To: akpm@linux-foundation.org, benh@kernel.crashing.org, paulus@samba.org Cc: mpe@ellerman.id.au, dave.hansen@linux.intel.com, tglx@linutronix.de, mingo@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Chen Gang , Chen Gang Subject: [PATCH] include: mman: Use bool instead of int for the return value of arch_validate_prot Date: Sun, 10 Jul 2016 00:29:11 +0800 Message-Id: <1468081751-9468-1-git-send-email-chengang@emindsoft.com.cn> X-Mailer: git-send-email 1.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chen Gang For pure bool function's return value, bool is a little better more or less than int. And return boolean result directly. Since 'if' statement is also for boolean checking, and return boolean result, too. Signed-off-by: Chen Gang --- arch/powerpc/include/asm/mman.h | 8 +++----- include/linux/mman.h | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/include/asm/mman.h b/arch/powerpc/include/asm/mman.h index 2563c43..62e1f47 100644 --- a/arch/powerpc/include/asm/mman.h +++ b/arch/powerpc/include/asm/mman.h @@ -31,13 +31,11 @@ static inline pgprot_t arch_vm_get_page_prot(unsigned long vm_flags) } #define arch_vm_get_page_prot(vm_flags) arch_vm_get_page_prot(vm_flags) -static inline int arch_validate_prot(unsigned long prot) +static inline bool arch_validate_prot(unsigned long prot) { if (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM | PROT_SAO)) - return 0; - if ((prot & PROT_SAO) && !cpu_has_feature(CPU_FTR_SAO)) - return 0; - return 1; + return false; + return (prot & PROT_SAO) == 0 || cpu_has_feature(CPU_FTR_SAO); } #define arch_validate_prot(prot) arch_validate_prot(prot) diff --git a/include/linux/mman.h b/include/linux/mman.h index 33e17f6..634c4c5 100644 --- a/include/linux/mman.h +++ b/include/linux/mman.h @@ -49,7 +49,7 @@ static inline void vm_unacct_memory(long pages) * * Returns true if the prot flags are valid */ -static inline int arch_validate_prot(unsigned long prot) +static inline bool arch_validate_prot(unsigned long prot) { return (prot & ~(PROT_READ | PROT_WRITE | PROT_EXEC | PROT_SEM)) == 0; } -- 1.9.3