From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751466AbdEBO0e (ORCPT ); Tue, 2 May 2017 10:26:34 -0400 Received: from mout.web.de ([217.72.192.78]:50059 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbdEBO0c (ORCPT ); Tue, 2 May 2017 10:26:32 -0400 Subject: [PATCH 2/6] md: Replace 17 seq_printf() calls by seq_puts() From: SF Markus Elfring To: linux-raid@vger.kernel.org, Neil Brown , Shaohua Li Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <146824c7-73ca-9f2e-99b8-d81ec2250bf2@users.sourceforge.net> Date: Tue, 2 May 2017 16:26:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:s9bmAUVtjWQXixBhuI7wIeaeDIu3KiCY6yJObt9umHdjK+UqCI3 l4ZL07y5TVrb01wxkRLIGIDVFVZnB0p5qy1v0JD28fEvIhZ7nrDDwA3F6bTd8s5O9cOLzP6 zqRu/DkmMb2AcAn37FrVg9qkRec74gWtr950g5g8AKtBA7nIYUrF5owODZ8MPQZESwGX8LK JNUPTvbdBnGVSXA+Owe6A== X-UI-Out-Filterresults: notjunk:1;V01:K0:WC8bOVt1z8M=:F0RYUZyoEIbpUW5y7vI/fX ANNFL2JquiLRCKQp3+N9yKW1tgA/U+i3LrsNLHrEbSi7O26Eu5jEHBZU54k4RfA6y7b69tRkj +YzwQJNU/+NhWLfh2IvYGtQx9XaS+iYs+I77ROePhZymhgCrH9kbs+YODirvnmYIwwNoJHKNa pubaS/vm7GxvlEDYFrhXDuCqXhrEgx8n8UpnKVj1dCT+QDKObNQXQnfX5tbNCfqDlIvA6js64 A0TLDn9HtodbDtozR2JSoaF6RRW0qdaYLzqO/GKTeG0Z8f/dkwC1lV36Jr4T3aXVjkXrKoZdR P4TqrkzX+kYZ7C0oIdB1//ooxSXN1sNZn7QVB+DPw8LE5bIhMpBbUuGncFwbgwBO0rKZ9rEcR KzxuWLqRxCb783AEttkGDLKkE7956z0+pmYEiJpWYw9gptTwyAdLegO/fSUVgE97YfX3HadzI eqrW+nb7SvTTjYevUyaV9Q7mj9DMog2dzHIbLE8XHF4ufFJqbZD6UcBXb9RXaqzmjYTQx0pqg CQ3h98iAcGvPPY7GDeXAJ4V0j7Zc+qKlerm6oXgKGyRYNGfFQ7xrFOAzq+maI3x3xzxV/PzFW vK7KP1zoWOJz0f1VNH5Ie6eOJ4SeGMPHDNWOMhuOxfIfW4MDcdAAxEby4bJ8grwmnKmHo8ZEf IW65cqYBnaJ8vk4ZABf0HqjMpdSE3EiSH0IiKOedVG5HWMhFnDRhsvgOqTmTiXY6jS7srnYT5 lJ3BykmLrB1/L1soZvjzNoJTby0VxMwQYwEVhPzsGojvG6wUkmqKjh5iFjNsnKjRtn42cO0yl Ilxjuwu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 2 May 2017 14:22:45 +0200 Strings which did not contain data format specifications should be put into a sequence. Thus use the corresponding function "seq_puts". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/md/md.c | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/drivers/md/md.c b/drivers/md/md.c index 7f0a35ee192a..65233a91e5e2 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -7487,7 +7487,7 @@ static void status_unused(struct seq_file *seq) int i = 0; struct md_rdev *rdev; - seq_printf(seq, "unused devices: "); + seq_puts(seq, "unused devices: "); list_for_each_entry(rdev, &pending_raid_disks, same_set) { char b[BDEVNAME_SIZE]; @@ -7496,7 +7496,7 @@ static void status_unused(struct seq_file *seq) bdevname(rdev->bdev,b)); } if (!i) - seq_printf(seq, ""); + seq_puts(seq, ""); seq_putc(seq, '\n'); } @@ -7525,13 +7525,13 @@ static int status_resync(struct seq_file *seq, struct mddev *mddev) if (resync == 0) { if (mddev->recovery_cp < MaxSector) { - seq_printf(seq, "\tresync=PENDING"); + seq_puts(seq, "\tresync=PENDING"); return 1; } return 0; } if (resync < 3) { - seq_printf(seq, "\tresync=DELAYED"); + seq_puts(seq, "\tresync=DELAYED"); return 1; } @@ -7559,7 +7559,7 @@ static int status_resync(struct seq_file *seq, struct mddev *mddev) seq_putc(seq, '>'); for (i = 0; i < y; i++) seq_putc(seq, '.'); - seq_printf(seq, "] "); + seq_puts(seq, "] "); } seq_printf(seq, " %s =%3u.%u%% (%llu/%llu)", (test_bit(MD_RECOVERY_RESHAPE, &mddev->recovery)? @@ -7673,7 +7673,8 @@ static int md_seq_show(struct seq_file *seq, void *v) if (v == (void*)1) { struct md_personality *pers; - seq_printf(seq, "Personalities : "); + + seq_puts(seq, "Personalities : "); spin_lock(&pers_lock); list_for_each_entry(pers, &pers_list, list) seq_printf(seq, "[%s] ", pers->name); @@ -7694,9 +7695,9 @@ static int md_seq_show(struct seq_file *seq, void *v) mddev->pers ? "" : "in"); if (mddev->pers) { if (mddev->ro==1) - seq_printf(seq, " (read-only)"); + seq_puts(seq, " (read-only)"); if (mddev->ro==2) - seq_printf(seq, " (auto-read-only)"); + seq_puts(seq, " (auto-read-only)"); seq_printf(seq, " %s", mddev->pers->name); } @@ -7707,17 +7708,17 @@ static int md_seq_show(struct seq_file *seq, void *v) seq_printf(seq, " %s[%d]", bdevname(rdev->bdev,b), rdev->desc_nr); if (test_bit(WriteMostly, &rdev->flags)) - seq_printf(seq, "(W)"); + seq_puts(seq, "(W)"); if (test_bit(Journal, &rdev->flags)) - seq_printf(seq, "(J)"); + seq_puts(seq, "(J)"); if (test_bit(Faulty, &rdev->flags)) { - seq_printf(seq, "(F)"); + seq_puts(seq, "(F)"); continue; } if (rdev->raid_disk < 0) - seq_printf(seq, "(S)"); /* spare */ + seq_puts(seq, "(S)"); /* spare */ if (test_bit(Replacement, &rdev->flags)) - seq_printf(seq, "(R)"); + seq_puts(seq, "(R)"); sectors += rdev->sectors; } rcu_read_unlock(); @@ -7742,17 +7743,18 @@ static int md_seq_show(struct seq_file *seq, void *v) seq_printf(seq, " super external:%s", mddev->metadata_type); else - seq_printf(seq, " super non-persistent"); + seq_puts(seq, " super non-persistent"); if (mddev->pers) { mddev->pers->status(seq, mddev); - seq_printf(seq, "\n "); + seq_puts(seq, "\n "); if (mddev->pers->sync_request) { if (status_resync(seq, mddev)) - seq_printf(seq, "\n "); + seq_puts(seq, "\n "); } - } else - seq_printf(seq, "\n "); + } else { + seq_puts(seq, "\n "); + } bitmap_status(seq, mddev->bitmap); seq_putc(seq, '\n'); -- 2.12.2