From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755381AbcGKQyS (ORCPT ); Mon, 11 Jul 2016 12:54:18 -0400 Received: from shelob.surriel.com ([74.92.59.67]:37898 "EHLO shelob.surriel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754339AbcGKQyR (ORCPT ); Mon, 11 Jul 2016 12:54:17 -0400 From: riel@redhat.com To: linux-kernel@vger.kernel.org Cc: peterz@infradead.org, mingo@kernel.org, pbonzini@redhat.com, fweisbec@redhat.com, wanpeng.li@hotmail.com, efault@gmx.de, tglx@linutronix.de, rkrcmar@redhat.com Subject: [PATCH 3/3] time: drop local_irq_save/restore from irqtime_account_irq Date: Mon, 11 Jul 2016 12:53:57 -0400 Message-Id: <1468256037-6307-4-git-send-email-riel@redhat.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468256037-6307-1-git-send-email-riel@redhat.com> References: <1468256037-6307-1-git-send-email-riel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rik van Riel Paolo pointed out that irqs are already blocked when irqtime_account_irq is called. That means there is no reason to call local_irq_save/restore again. Signed-off-by: Rik van Riel Suggested-by: Paolo Bonzini --- kernel/sched/cputime.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c index ca7e33cb0967..7b6fa4d7ad4c 100644 --- a/kernel/sched/cputime.c +++ b/kernel/sched/cputime.c @@ -49,15 +49,12 @@ DEFINE_PER_CPU(seqcount_t, irq_time_seq); */ void irqtime_account_irq(struct task_struct *curr) { - unsigned long flags; s64 delta; int cpu; if (!sched_clock_irqtime) return; - local_irq_save(flags); - cpu = smp_processor_id(); delta = sched_clock_cpu(cpu) - __this_cpu_read(irq_start_time); __this_cpu_add(irq_start_time, delta); @@ -75,7 +72,6 @@ void irqtime_account_irq(struct task_struct *curr) __this_cpu_add(cpu_softirq_time, delta); irq_time_write_end(); - local_irq_restore(flags); } EXPORT_SYMBOL_GPL(irqtime_account_irq); -- 2.7.4