From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877AbcGKXDd (ORCPT ); Mon, 11 Jul 2016 19:03:33 -0400 Received: from lists.s-osg.org ([54.187.51.154]:58022 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751227AbcGKXDE (ORCPT ); Mon, 11 Jul 2016 19:03:04 -0400 From: Luis de Bethencourt To: linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, salah.triki@gmail.com, Luis de Bethencourt Subject: [PATCH 2/3] befs: in memory free_node_ptr and max_size never read Date: Tue, 12 Jul 2016 00:02:49 +0100 Message-Id: <1468278170-3550-2-git-send-email-luisbg@osg.samsung.com> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1468278170-3550-1-git-send-email-luisbg@osg.samsung.com> References: <1468278170-3550-1-git-send-email-luisbg@osg.samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The only place the values of free_node_ptr and max_size are read is in befs_dump_index_entry(), which both times it is called, it is passed the on disk superblock. Removing assignment of unused values. Signed-off-by: Luis de Bethencourt --- Hi, Noticed this when reading befs' btree code. Thanks, Luis fs/befs/btree.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/befs/btree.c b/fs/befs/btree.c index 3995d58..2b5b635 100644 --- a/fs/befs/btree.c +++ b/fs/befs/btree.c @@ -156,8 +156,6 @@ befs_bt_read_super(struct super_block *sb, const befs_data_stream *ds, sup->max_depth = fs32_to_cpu(sb, od_sup->max_depth); sup->data_type = fs32_to_cpu(sb, od_sup->data_type); sup->root_node_ptr = fs64_to_cpu(sb, od_sup->root_node_ptr); - sup->free_node_ptr = fs64_to_cpu(sb, od_sup->free_node_ptr); - sup->max_size = fs64_to_cpu(sb, od_sup->max_size); brelse(bh); if (sup->magic != BEFS_BTREE_MAGIC) { -- 2.5.3