From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: David Airlie <airlied@linux.ie>,
Philipp Zabel <p.zabel@pengutronix.de>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Daniel Vetter <daniel@ffwll.ch>
Cc: "Lothar Waßmann" <LW@KARO-electronics.de>
Subject: [PATCHv4 1/3] drm/imx: parallel-display: check return code from of_get_drm_display_mode()
Date: Tue, 12 Jul 2016 15:30:01 +0200 [thread overview]
Message-ID: <1468330203-29150-2-git-send-email-LW@KARO-electronics.de> (raw)
In-Reply-To: <1468330203-29150-1-git-send-email-LW@KARO-electronics.de>
of_get_drm_display_mode() may fail. Check its return code and bail out
on error.
Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
---
drivers/gpu/drm/imx/parallel-display.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/parallel-display.c b/drivers/gpu/drm/imx/parallel-display.c
index 2d1fd02..4b2ec5d 100644
--- a/drivers/gpu/drm/imx/parallel-display.c
+++ b/drivers/gpu/drm/imx/parallel-display.c
@@ -69,10 +69,16 @@ static int imx_pd_connector_get_modes(struct drm_connector *connector)
if (np) {
struct drm_display_mode *mode = drm_mode_create(connector->dev);
+ int ret;
if (!mode)
return -EINVAL;
- of_get_drm_display_mode(np, &imxpd->mode, OF_USE_NATIVE_MODE);
+
+ ret = of_get_drm_display_mode(np, &imxpd->mode,
+ OF_USE_NATIVE_MODE);
+ if (ret)
+ return ret;
+
drm_mode_copy(mode, &imxpd->mode);
mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
drm_mode_probed_add(connector, mode);
--
2.1.4
next prev parent reply other threads:[~2016-07-12 13:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 13:18 [PATCHv3 1/1] drm/imx: convey the pixelclk-active and de-active flags from DT to the ipu-di driver Lothar Waßmann
2016-07-12 11:54 ` Lothar Waßmann
2016-07-12 12:43 ` Daniel Vetter
2016-07-12 16:50 ` Philipp Zabel
2016-07-12 16:49 ` Philipp Zabel
2016-07-12 13:30 ` [PATCHv4 0/3] " Lothar Waßmann
2016-07-12 13:30 ` Lothar Waßmann [this message]
2016-07-12 13:30 ` [PATCHv4 2/3] drm: add a helper function to extract 'de-active' and 'pixelclk-active' from DT Lothar Waßmann
2016-08-15 14:33 ` Daniel Vetter
2016-07-12 13:30 ` [PATCHv4 3/3] drm/imx: convey the pixelclk-active and de-active flags from DT to the ipu-di driver Lothar Waßmann
2016-07-12 14:39 ` [PATCHv3 1/1] " Thierry Reding
2016-07-12 16:49 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468330203-29150-2-git-send-email-LW@KARO-electronics.de \
--to=lw@karo-electronics.de \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome