From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755877AbcGLQw2 (ORCPT ); Tue, 12 Jul 2016 12:52:28 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:59942 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755099AbcGLQuZ (ORCPT ); Tue, 12 Jul 2016 12:50:25 -0400 Message-ID: <1468342218.2796.31.camel@pengutronix.de> Subject: Re: [PATCHv3 1/1] drm/imx: convey the pixelclk-active and de-active flags from DT to the ipu-di driver From: Philipp Zabel To: Daniel Vetter Cc: Lothar =?ISO-8859-1?Q?Wa=DFmann?= , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Tue, 12 Jul 2016 18:50:18 +0200 In-Reply-To: <20160712124309.GV23520@phenom.ffwll.local> References: <1464182296-23812-1-git-send-email-LW@KARO-electronics.de> <20160712135428.4a348a06@ipc1.ka-ro> <20160712124309.GV23520@phenom.ffwll.local> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 12.07.2016, 14:43 +0200 schrieb Daniel Vetter: > On Tue, Jul 12, 2016 at 01:54:28PM +0200, Lothar Waßmann wrote: > > Hi, > > > > On Wed, 25 May 2016 15:18:16 +0200 Lothar Waßmann wrote: > > > The 'de-active' and 'pixelclk-active' DT properties are evaluated > > > by of_parse_display_timing() called from of_get_drm_display_mode(), > > > but later lost in the conversion from videomode.flags to > > > drm_display_mode.flags. > > > Use an open coded version of of_get_drm_display_mode() to get access > > > to these flags and make sure they are passed on to the ipu-di driver. > > > > > > Changes vs. v2: > > > - removed patches which have already been applied > > > - created a drm_bus_flags_from_videomode() helper to prevent code > > > duplication as suggested by Philipp Zabel > > > > > > Changes vs. v1: > > > - rebased on top of https://patchwork.kernel.org/patch/9113791/ as > > > per Philipp Zabel's request > > > > > > GIT: [PATCHv2 1/3] drm/imx: imx-ldb: honor 'native-mode' property when > > > GIT: [PATCHv2 2/3] drm/imx: convey the pixelclk-active and de-active flags > > > GIT: [PATCHv2 3/3] drm/imx: remove dead code > > Should this be split up into 3 patches? At least it's good practice to > split up the drm core helper functions into it's own patch, instead of > hiding it behind something with the drm/imx prefix - no one will spot it > that way. > > > Ping?! > > If imx maintainers keep being asleep at the helm I can merge this through > drm-misc, but I'd like some more tested-by from other folks if possible. > Even better when there's a review. This clashes with the atomic modeset changes. If you don't disagree with the core change, I can include it with the next imx-drm/next pull request. regards Philipp