From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753249AbcGMOvI (ORCPT ); Wed, 13 Jul 2016 10:51:08 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:36092 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751931AbcGMOus (ORCPT ); Wed, 13 Jul 2016 10:50:48 -0400 From: Frederic Weisbecker To: Ingo Molnar Cc: LKML , Rik van Riel , Paolo Bonzini , Peter Zijlstra , Wanpeng Li , Thomas Gleixner , Radim Krcmar , Frederic Weisbecker , Mike Galbraith Subject: [PATCH 5/5] time: Drop local_irq_save/restore from irqtime_account_irq Date: Wed, 13 Jul 2016 16:50:05 +0200 Message-Id: <1468421405-20056-6-git-send-email-fweisbec@gmail.com> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1468421405-20056-1-git-send-email-fweisbec@gmail.com> References: <1468421405-20056-1-git-send-email-fweisbec@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rik van Riel Paolo pointed out that irqs are already blocked when irqtime_account_irq is called. That means there is no reason to call local_irq_save/restore again. Suggested-by: Paolo Bonzini Reviewed-by: Paolo Bonzini Signed-off-by: Rik van Riel Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Paolo Bonzini Cc: Wanpeng Li Cc: Mike Galbraith Cc: Thomas Gleixner Cc: Radim Krcmar Signed-off-by: Frederic Weisbecker --- kernel/sched/cputime.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c index 16a873c..ea0f6f3 100644 --- a/kernel/sched/cputime.c +++ b/kernel/sched/cputime.c @@ -49,15 +49,12 @@ DEFINE_PER_CPU(seqcount_t, irq_time_seq); */ void irqtime_account_irq(struct task_struct *curr) { - unsigned long flags; s64 delta; int cpu; if (!sched_clock_irqtime) return; - local_irq_save(flags); - cpu = smp_processor_id(); delta = sched_clock_cpu(cpu) - __this_cpu_read(irq_start_time); __this_cpu_add(irq_start_time, delta); @@ -75,7 +72,6 @@ void irqtime_account_irq(struct task_struct *curr) __this_cpu_add(cpu_softirq_time, delta); irq_time_write_end(); - local_irq_restore(flags); } EXPORT_SYMBOL_GPL(irqtime_account_irq); -- 2.7.0