From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751746AbcGOMpv (ORCPT ); Fri, 15 Jul 2016 08:45:51 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:37288 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbcGOMpt (ORCPT ); Fri, 15 Jul 2016 08:45:49 -0400 Message-ID: <1468586744.7213.32.camel@pengutronix.de> Subject: Re: [PATCH 02/16] gpu: ipu-cpmem: Add ipu_cpmem_set_uv_offset() From: Philipp Zabel To: Steve Longerbeam Cc: Steve Longerbeam , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Fri, 15 Jul 2016 14:45:44 +0200 In-Reply-To: <5786C69A.3070301@mentor.com> References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-3-git-send-email-steve_longerbeam@mentor.com> <1467999263.2365.72.camel@pengutronix.de> <5786C69A.3070301@mentor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, den 13.07.2016, 15:54 -0700 schrieb Steve Longerbeam: > Hi Philipp, > > On 07/08/2016 10:34 AM, Philipp Zabel wrote: > > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: > >> Adds ipu_cpmem_set_uv_offset(), to set planar U/V offsets. > >> > >> Signed-off-by: Steve Longerbeam > >> --- > >> drivers/gpu/ipu-v3/ipu-cpmem.c | 7 +++++++ > >> include/video/imx-ipu-v3.h | 1 + > >> 2 files changed, 8 insertions(+) > >> > >> diff --git a/drivers/gpu/ipu-v3/ipu-cpmem.c b/drivers/gpu/ipu-v3/ipu-cpmem.c > >> index 6494a4d..a36c35e 100644 > >> --- a/drivers/gpu/ipu-v3/ipu-cpmem.c > >> +++ b/drivers/gpu/ipu-v3/ipu-cpmem.c > >> @@ -253,6 +253,13 @@ void ipu_cpmem_set_buffer(struct ipuv3_channel *ch, int bufnum, dma_addr_t buf) > >> } > >> EXPORT_SYMBOL_GPL(ipu_cpmem_set_buffer); > >> > >> +void ipu_cpmem_set_uv_offset(struct ipuv3_channel *ch, u32 u_off, u32 v_off) > >> +{ > >> + ipu_ch_param_write_field(ch, IPU_FIELD_UBO, u_off / 8); > >> + ipu_ch_param_write_field(ch, IPU_FIELD_VBO, v_off / 8); > >> +} > >> +EXPORT_SYMBOL_GPL(ipu_cpmem_set_uv_offset); > >> + > > I'd prefer to avoid too much duplication in the API. Is there a reason > > you can't use ipu_cpmem_set_yuv_planar_full? > > I could, but it would be cumbersome. ipu_cpmem_set_uv_offset() is being > called when kicking off a new tile conversion, and the stride length would > have to be calculated all over again if I were to use ipu_cpmem_set_yuv_planar_ful(). > When kicking off a new tile conversion, the stride doesn't change, only the > tile's buffer address, and U/V offsets for planar, need to be updated. Ok. We'll have to change tile width and height as well, but the stride indeed is constant. regards Philipp