From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbcGOMpz (ORCPT ); Fri, 15 Jul 2016 08:45:55 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:57523 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbcGOMpw (ORCPT ); Fri, 15 Jul 2016 08:45:52 -0400 Message-ID: <1468586749.7213.33.camel@pengutronix.de> Subject: Re: [PATCH 07/16] gpu: ipu-v3: Add VDI input IDMAC channels From: Philipp Zabel To: Steve Longerbeam Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Steve Longerbeam Date: Fri, 15 Jul 2016 14:45:49 +0200 In-Reply-To: <1467932621-358-8-git-send-email-steve_longerbeam@mentor.com> References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-8-git-send-email-steve_longerbeam@mentor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: > Adds the VDIC field input IDMAC channels. These channels > transfer fields F(n-1), F(n), and F(N+1) from memory to > the VDIC (channels 8, 9, 10 respectively). > > Signed-off-by: Steve Longerbeam > --- > include/video/imx-ipu-v3.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h > index 586979e..2302fc5 100644 > --- a/include/video/imx-ipu-v3.h > +++ b/include/video/imx-ipu-v3.h > @@ -107,6 +107,9 @@ enum ipu_channel_irq { > #define IPUV3_CHANNEL_CSI2 2 > #define IPUV3_CHANNEL_CSI3 3 > #define IPUV3_CHANNEL_VDI_MEM_IC_VF 5 > +#define IPUV3_CHANNEL_MEM_VDI_P 8 > +#define IPUV3_CHANNEL_MEM_VDI 9 > +#define IPUV3_CHANNEL_MEM_VDI_N 10 I would prefer the names to be just a bit more descriptive: #define IPUV3_CHANNEL_MEM_VDI_PREV 8 #define IPUV3_CHANNEL_MEM_VDI_CUR 9 #define IPUV3_CHANNEL_MEM_VDI_NEXT 10 The reference manual states that the purposes of these channels are "Previous field", "Current field", and "Next field" input to the VDIC, respectively. regards Philipp