From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751262AbcGOMst (ORCPT ); Fri, 15 Jul 2016 08:48:49 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:43007 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751032AbcGOMss (ORCPT ); Fri, 15 Jul 2016 08:48:48 -0400 Message-ID: <1468586926.7213.36.camel@pengutronix.de> Subject: Re: [PATCH 06/16] gpu: ipu-v3: Add ipu_set_vdi_src_mux() From: Philipp Zabel To: Steve Longerbeam Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Steve Longerbeam Date: Fri, 15 Jul 2016 14:48:46 +0200 In-Reply-To: <1467932621-358-7-git-send-email-steve_longerbeam@mentor.com> References: <1467932621-358-1-git-send-email-steve_longerbeam@mentor.com> <1467932621-358-7-git-send-email-steve_longerbeam@mentor.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: > Adds ipu_set_vdi_src_mux() that selects the VDIC input > (from CSI or memory). > > Signed-off-by: Steve Longerbeam > --- > drivers/gpu/ipu-v3/ipu-common.c | 20 ++++++++++++++++++++ > include/video/imx-ipu-v3.h | 1 + > 2 files changed, 21 insertions(+) > > diff --git a/drivers/gpu/ipu-v3/ipu-common.c b/drivers/gpu/ipu-v3/ipu-common.c > index 6d1676e..374100e 100644 > --- a/drivers/gpu/ipu-v3/ipu-common.c > +++ b/drivers/gpu/ipu-v3/ipu-common.c > @@ -730,6 +730,26 @@ void ipu_set_ic_src_mux(struct ipu_soc *ipu, int csi_id, bool vdi) > } > EXPORT_SYMBOL_GPL(ipu_set_ic_src_mux); > > +/* > + * Set the source for the VDIC. Selects either from CSI[01] or memory. > + */ > +void ipu_set_vdi_src_mux(struct ipu_soc *ipu, bool csi) > +{ > + unsigned long flags; > + u32 val; > + > + spin_lock_irqsave(&ipu->lock, flags); > + > + val = ipu_cm_read(ipu, IPU_FS_PROC_FLOW1); > + val &= ~(0x3 << 28); > + if (csi) > + val |= (0x01 << 28); This doesn't set a bus mux, or does it? As I understand it, this configures the FSU to trigger the VDIC conversion from the CSI direct channel sync signals (IC channel CB7). As such I believe this belongs together with the other channel linking code, maybe even in ipu-fsu.c. Also, some #defines would be nice, for example: #define FS_VDI_SRC_SEL_MASK (0x3 << 28) #define FS_VDI_SRC_SEL_OFFSET 28 #define FS_VDI_SRC_SEL_CSI_DIRECT 0x1 #define FS_VDI_SRC_SEL_VDOA 0x2 regards Philipp