From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753402AbcGSLuF (ORCPT ); Tue, 19 Jul 2016 07:50:05 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34377 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752979AbcGSLuD (ORCPT ); Tue, 19 Jul 2016 07:50:03 -0400 From: Paolo Bonzini To: linux-kernel@vger.kernel.org Cc: Thomas Renninger , Peter Zijlstra , rjw@rjwysocki.net, linux-pm@vger.kernel.org, Jacob Pan , Andy Lutomirski Subject: [PATCH resend] intel_rapl: downgrade message if no RAPL domains found in a VM Date: Tue, 19 Jul 2016 13:49:57 +0200 Message-Id: <1468928997-20431-1-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org People complain about the driver saying there's no valid RAPL domains in a VM, and doing so at KERN_ERR severity. Downgrade this to KERN_INFO if running on a hypervisor, since it is basically stating the obvious. Suggested-by: Peter Zijlstra Cc: Jacob Pan Cc: Andy Lutomirski Signed-off-by: Paolo Bonzini --- First sent out about a year ago. :) drivers/powercap/intel_rapl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/powercap/intel_rapl.c b/drivers/powercap/intel_rapl.c index b2766b867b0e..0a0b09910116 100644 --- a/drivers/powercap/intel_rapl.c +++ b/drivers/powercap/intel_rapl.c @@ -1392,7 +1392,9 @@ static int rapl_detect_domains(struct rapl_package *rp, int cpu) } rp->nr_domains = bitmap_weight(&rp->domain_map, RAPL_DOMAIN_MAX); if (!rp->nr_domains) { - pr_err("no valid rapl domains found in package %d\n", rp->id); + printk("%sNo valid RAPL domains found in package %d\n", + boot_cpu_has(X86_FEATURE_HYPERVISOR) ? KERN_INFO : KERN_ERR, + rp->id); ret = -ENODEV; goto done; } -- 2.7.4