From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753254AbcGSMCi (ORCPT ); Tue, 19 Jul 2016 08:02:38 -0400 Received: from m12-12.163.com ([220.181.12.12]:44844 "EHLO m12-12.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752743AbcGSMCf (ORCPT ); Tue, 19 Jul 2016 08:02:35 -0400 From: Wei Yongjun To: Alexey Brodkin , David Airlie Cc: Wei Yongjun , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH -next] drm/arc: Remove redundant dev_err call in arcpgu_load() Date: Tue, 19 Jul 2016 12:01:37 +0000 Message-Id: <1468929697-8648-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-CM-TRANSID: DMCowACHrxeiFo5XtsSAAQ--.39244S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wr4kCw4kuF47tr4DGr45Jrb_yoWDXrc_Cr WDZwn7XwnIyF4qqF98C3W5AFy3tFsF9FWfXF1qqa43tryUX3y2gryqkw18Xr1DXwsIkFZ8 Aws8Xr4ayrsxCjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0WKZJUUUUU== X-Originating-IP: [180.110.255.208] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/xtbBDQOr1laDoIKktQAAsV Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/gpu/drm/arc/arcpgu_drv.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c index 0226ec0..ef1d702 100644 --- a/drivers/gpu/drm/arc/arcpgu_drv.c +++ b/drivers/gpu/drm/arc/arcpgu_drv.c @@ -104,10 +104,8 @@ static int arcpgu_load(struct drm_device *drm) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); arcpgu->regs = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(arcpgu->regs)) { - dev_err(drm->dev, "Could not remap IO mem\n"); + if (IS_ERR(arcpgu->regs)) return PTR_ERR(arcpgu->regs); - } dev_info(drm->dev, "arc_pgu ID: 0x%x\n", arc_pgu_read(arcpgu, ARCPGU_REG_ID));