From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751545AbcGTEVU (ORCPT ); Wed, 20 Jul 2016 00:21:20 -0400 Received: from alt13.smtp-out.videotron.ca ([135.19.0.26]:28639 "EHLO alt12.smtp-out.videotron.ca" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751539AbcGTEUv (ORCPT ); Wed, 20 Jul 2016 00:20:51 -0400 X-Authority-Analysis: v=2.1 cv=Lv0ysipc c=1 sm=1 tr=0 a=keA3yYpnlypCNW5BNWqu+w==:117 a=keA3yYpnlypCNW5BNWqu+w==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=cAmyUtKerLwA:10 a=KKAkSRfTAAAA:8 a=tBb2bbeoAAAA:8 a=0uNKG0NQF1f1rLkwhCQA:9 a=cvBusfyB2V15izCimMoJ:22 a=Oj-tNtZlA1e06AYgeCfH:22 From: Nicolas Pitre To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alexander Viro , David Howells , Greg Ungerer Subject: [PATCH v3 09/12] binfmt_flat: use clear_user() rather than memset() to clear .bss Date: Wed, 20 Jul 2016 00:20:21 -0400 Message-Id: <1468988424-32671-10-git-send-email-nicolas.pitre@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1468988424-32671-1-git-send-email-nicolas.pitre@linaro.org> References: <1468988424-32671-1-git-send-email-nicolas.pitre@linaro.org> X-CMAE-Envelope: MS4wfBRvEFyto/BLsPw9fTusFdv1hVZ/Iit08Px+X8/x9X+azJpNYAtHyuW7mcD5ltEfOJUZIkUR0zWIZQMh4cy6Odyr12PGcymh8iqFsxZMvxVUoLPtlRas 7avyIFW1PFk5s8ZbX/uXg3TTrrEoUj2tFrrhVGsctiYz2cTHbHi+3ZytktxkMGBKlNIP6yKZiiOnCINlNpDnLMycpEFa/g+qIT/IOHh0gop9YhNGuzhK7Vid aksMXoIPn83M0FgcNMa8ktf+GR00jg9FMiJ4xVd+yCtHLYG2t77cK2pmEBEQKGiFJrWbR24NWY8tmdjjonYmfg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is needed on systems with a MMU. Signed-off-by: Nicolas Pitre Reviewed-by: Greg Ungerer --- fs/binfmt_flat.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index 28fc272d9a..0d89830f76 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -798,10 +798,11 @@ static int load_flat_file(struct linux_binprm * bprm, flush_icache_range(start_code, end_code); /* zero the BSS, BRK and stack areas */ - memset((void*)(datapos + data_len), 0, bss_len + + if (clear_user((void __user *)(datapos + data_len), bss_len + (memp + memp_size - stack_len - /* end brk */ libinfo->lib_list[id].start_brk) + /* start brk */ - stack_len); + stack_len)) + return -EFAULT; return 0; err: -- 2.7.4