From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FD0B1632DF for ; Sat, 11 Jan 2025 10:03:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736589809; cv=none; b=msQVWa2BUElNI+/f9CF4yppq4SV8IUSORTEqFTeIbZlaildyIUcJfj+E1llQz0BwX+M3kOiVfF/en/Z/BKVKyWK3y3nfSdQcpP/c7PicUk+pXsZpyiQV4if62wLmiWWRQgcKankUy1o9DVZVcoiXK7ZHly1bedt04rSOLpdHOf4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736589809; c=relaxed/simple; bh=i/UM04K77JEbX9LkP3YPpCdobeU1V78wd+itjqCxwZ8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gVmHpCOTddsw0XFQNfVi3hJiRnW7/eaNbOvG4rCaCJtB9bGJSvHNuD/XOLkC+DucKM9D82S91TtjLkvGnFmOER42NEvewMM3BMBo/jDK/PeE1m9j1qaNjtSTI8Hzi8rdbhnWSWLO3qNaka07/lXI6kE2IDy3v6L8QTLsKpneMzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EFt74oZL; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EFt74oZL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736589806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=bdLPllsNKcroQKaJckZ27aAerUfL4hT2TBF+GYVpZwo=; b=EFt74oZLtPhdmpjkWkuNssIN/RRCigteCW97N/KAUKODcsj0SWkRJd2ynQOV3ghc0bWMXD lCINK9DEIvZRu7a4wbq1V3zotDV4Cnum12R6VuJmAX7E22uaeDoCQQKJUF+cpXhRgkUHCD 7WaZx2gaWrNWYHnz/ZjLNodQg/WTaBE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-307-FKkLCybYM4Kcqj2W2p-Ycg-1; Sat, 11 Jan 2025 05:03:22 -0500 X-MC-Unique: FKkLCybYM4Kcqj2W2p-Ycg-1 X-Mimecast-MFC-AGG-ID: FKkLCybYM4Kcqj2W2p-Ycg Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4362552ce62so14098565e9.0 for ; Sat, 11 Jan 2025 02:03:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736589801; x=1737194601; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=bdLPllsNKcroQKaJckZ27aAerUfL4hT2TBF+GYVpZwo=; b=HqtlVs2fYWnCn9bZuCPJQUIg6snnPMfvVRl/PNZ6yzrtfM4jKZAHKP+IOqM6KK9fV0 t558tdBpQV4uOKGPFM1aOHPURzy9f+lU2X9l2s3G5rwWmEeYM1/yHX+/Fgb0yU4gI5cT E/SNYH+qC9/rwCwiVMhheXnVV3of6yt/nrbn0vwtX4wi5/sL8vR+LJdnvxQREjiq2hKx WokA8FIBDbhU2xMmStkcRKBEa9VnHQ8YWDuKKeLRENRWvf/QZxyxNeIvBor/voRSz2mV V9hsTzR4G7Rx9de/G9BKaEifGJY0kp2+xCM965WR7HT8ZRnNKAV+k/UC2r0qBo3ev2Gk rclA== X-Forwarded-Encrypted: i=1; AJvYcCWssTlGA6VICRGErNA8IL32HwprDTFu2sAWT/c5Y07MbP5FJ+2TE2VoqIcZ8Eto2keOG6y/xqsKnMXMy2A=@vger.kernel.org X-Gm-Message-State: AOJu0YyVa+WoMqdSNIXZCRCC+008NTQiPdxXk+kB5oWXzkvWrdlkfHP/ p4xeCKaiEvRc+7JTa/A4cbv6LpLVe1wOvfcuSpnPwvEuxlRbNxvF2GwQegyKUnmt27mMiPwZl9W cNllmeB+GyI3HTRX3dd9RpFdK6nGqysip2HgyypiQ5UbLCd53YUAP/pwu8sjbSA== X-Gm-Gg: ASbGncvf9phlmh1kLP4N7D9og5GzWuzMMi8O+0H3gSVgEulEd8rt2IOcQHkf4EIRa+l Z8pJz4q4eftwcVxKuULb0R7sNjm8ckT6uDCYomF8x5fpzi6tXmlYMsRef3uk+6ZdCGT2Wp6kaSm Fgf+HdOIkih9QzFGwWP5/Svz4u3uT1HSIWio6krp7wafY4mCIYndhRrc35H1F4VapfxMbAyVrzl GOg8SOwyXDkawibvGQYq3Em0ZFM/5dgJOjMaVrZfQcr89biLnmUqvyz1eWuoFvzaTvsgbRRkiE7 GQYRrdNOeej4fjuTcmnFh47E+kc9oemBOvQqgCg+yb6wH5DXygUVh3iqwFaDx1OVeoyAdXbjlx+ AiRQ/bgOQ X-Received: by 2002:a05:600c:3b2a:b0:434:f623:9ff3 with SMTP id 5b1f17b1804b1-436e26a8c3cmr134859365e9.15.1736589801113; Sat, 11 Jan 2025 02:03:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IH/lxRmg7UrpgVWl1Z4SNK14ZltIiePfJb8Aej5HMhpyE13Oi8DQ5I4eqyY7pGjL1bQcKJ+xg== X-Received: by 2002:a05:600c:3b2a:b0:434:f623:9ff3 with SMTP id 5b1f17b1804b1-436e26a8c3cmr134859005e9.15.1736589800600; Sat, 11 Jan 2025 02:03:20 -0800 (PST) Received: from ?IPV6:2003:cb:c714:a300:c534:35c3:a7d9:f55c? (p200300cbc714a300c53435c3a7d9f55c.dip0.t-ipconnect.de. [2003:cb:c714:a300:c534:35c3:a7d9:f55c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9d8fc5csm78761495e9.2.2025.01.11.02.03.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jan 2025 02:03:19 -0800 (PST) Message-ID: <1468cf2b-f4ff-4e32-9491-ad91e48d041b@redhat.com> Date: Sat, 11 Jan 2025 11:03:17 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] WARNING in __folio_rmap_sanity_checks (2) To: Hillf Danton Cc: syzbot , linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <20241231084108.1146-1-hdanton@sina.com> <20250111010103.1615-1-hdanton@sina.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250111010103.1615-1-hdanton@sina.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11.01.25 02:00, Hillf Danton wrote: > On Fri, 10 Jan 2025 17:35:25 +0100 David Hildenbrand >> On 31.12.24 09:41, Hillf Danton wrote: >>> On Fri, 27 Dec 2024 20:56:21 -0800 >>>> syzbot has found a reproducer for the following issue on: >>>> >>>> HEAD commit: 8155b4ef3466 Add linux-next specific files for 20241220 >>>> git tree: linux-next >>>> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1652fadf980000 >>> >>> #syz test >>> >>> --- x/mm/filemap.c >>> +++ y/mm/filemap.c >>> @@ -3636,6 +3636,10 @@ static vm_fault_t filemap_map_folio_rang >>> continue; >>> skip: >>> if (count) { >>> + for (unsigned int i = 0; i < count; i++) { >>> + if (page_folio(page + i) != folio) >>> + goto out; >>> + } >> >> IIRC, count <= nr_pages. Wouldn't that mean that we somehow pass in >> nr_pages that already exceeds the given folio+start? >> >> When I last looked at this, I was not able to spot the error in the >> caller :( >> > This is a debug patch at the first place, and this hunk overlaps with the > next one. Yeah, I was rather wondering if you had any clue why that hunk might help on its own. -- Cheers, David / dhildenb