From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752915AbcGTHjF (ORCPT ); Wed, 20 Jul 2016 03:39:05 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:39521 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbcGTHiz (ORCPT ); Wed, 20 Jul 2016 03:38:55 -0400 X-AuditID: cbfee68e-f79266d000001428-cb-578f2a8849b6 From: Chanwoo Choi To: linux-kernel@vger.kernel.org Cc: cw00.choi@samsung.com, myungjoo.ham@samsung.com, ckeepax@opensource.wolfsonmicro.com, patches@opensource.wolfsonmicro.com Subject: [PATCH 1/4] extcon: arizona: Remove the usage of extcon_update_state() Date: Wed, 20 Jul 2016 16:38:44 +0900 Message-id: <1469000327-15615-2-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1469000327-15615-1-git-send-email-cw00.choi@samsung.com> References: <1469000327-15615-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsWyRsSkQLdDqz/c4EoXn8W/KTfYLa5/ec5q cXnXHDaL240r2CyWv/3P5sDq8XLibzaPvi2rGD0+b5ILYI7isklJzcksSy3St0vgyjg24QNb QQN3xbcVB9gbGPs5uxg5OSQETCTe71nHBGGLSVy4t56ti5GLQ0hgBaPEpbvf2WGKulbOYIFI LGWUOPDiLDuE84VRYtOlXrB2NgEtif0vbrCB2CICChKbe5+xgtjMAvUSx2a9BqsRFvCXOL92 PZjNIqAq8WLTZkYQm1fAVeLo+n9sENvkJD7seQS2mVPATWLT+efMILYQUM2WjeehaprZJXo+ iULMEZD4NvkQ0HUcQHFZiU0HmCFKJCUOrrjBMoFReAEjwypG0dSC5ILipPQiI73ixNzi0rx0 veT83E2MwPA9/e9Z3w7GmwesDzEKcDAq8fBGHOwLF2JNLCuuzD3EaAq0YSKzlGhyPjBK8kri DY3NjCxMTUyNjcwtzZTEeROkfgYLCaQnlqRmp6YWpBbFF5XmpBYfYmTi4JRqYHTS5wy1d4to lBS1Xpe/onB/ht2hYD7eyrgj+zecnrDS8OFplmiGpTNe697a1HZnC8fBJX+3nl8wN373ect1 G39XlFyN1v75s/DunY2Wz686xFiFexoH9m5ibb9pO6/0DeMWdQnOI3zNp9TWvhG3qWoo35Xf Y3PZSUovbWPiufoUe25tJhbDECWW4oxEQy3mouJEAFEzOmdaAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsVy+t9jAd0Orf5wg12HOC3+TbnBbnH9y3NW i8u75rBZ3G5cwWax/O1/NgdWj5cTf7N59G1ZxejxeZNcAHNUA6NNRmpiSmqRQmpecn5KZl66 rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtBOJYWyxJxSoFBAYnGxkr4dpgmhIW66 FjCNEbq+IUFwPUYGaCBhDWPGsQkf2AoauCu+rTjA3sDYz9nFyMkhIWAi0bVyBguELSZx4d56 ti5GLg4hgaWMEgdenGWHcL4wSmy61MsEUsUmoCWx/8UNNhBbREBBYnPvM1YQm1mgXuLYrNdg NcIC/hLn164Hs1kEVCVebNrMCGLzCrhKHF3/jw1im5zEhz2P2EFsTgE3iU3nnzOD2EJANVs2 nmebwMi7gJFhFaNEakFyQXFSeq5hXmq5XnFibnFpXrpecn7uJkZwlDyT2sF4cJf7IUYBDkYl Ht6Ig33hQqyJZcWVuYcYJTiYlUR416j1hwvxpiRWVqUW5ccXleakFh9iNAU6bCKzlGhyPjCC 80riDY1NzIwsjcwNLYyMzZXEeR//XxcmJJCeWJKanZpakFoE08fEwSnVwMi2fpZYzoQdEqn6 /8+tvFK/Z3cXt3KwYlD3Xs7/aWzxs4quz7uYv5/l8rKoaW+tW2V/GR7n+nbwtLZFuJj8znKd QAeWJ8bOP5jnGdZGmOdMPHPhy7uuXQcPsD1crMm5R5op54RmW3XznqleUqbVDy97f/kf99a0 +KDUyoZ3YdsUmtKi9mw2WK/EUpyRaKjFXFScCACG2zmOqAIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch remvoes the usage of extcon_update_state() because the extcon_update_state() use directly the bit masking calculation to change the state of external connector without the unique id of external connector. It makes the code diffcult to read it. So, this patch uses the extcon_set_cable_state_() instead. Cc: Charles Keepax Cc: patches@opensource.wolfsonmicro.com Signed-off-by: Chanwoo Choi --- drivers/extcon/extcon-arizona.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c index 1d8e0a57bd51..a7161ecd0a1a 100644 --- a/drivers/extcon/extcon-arizona.c +++ b/drivers/extcon/extcon-arizona.c @@ -1149,10 +1149,13 @@ static irqreturn_t arizona_jackdet(int irq, void *data) info->micd_ranges[i].key, 0); input_sync(info->input); - ret = extcon_update_state(info->edev, 0xffffffff, 0); - if (ret != 0) - dev_err(arizona->dev, "Removal report failed: %d\n", - ret); + for (i = 0; i < ARRAY_SIZE(arizona_cable) - 1; i++) { + ret = extcon_set_cable_state_(info->edev, + arizona_cable[i], false); + if (ret != 0) + dev_err(arizona->dev, + "Removal report failed: %d\n", ret); + } regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_DEBOUNCE, -- 1.9.1