From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752959AbcGTHjJ (ORCPT ); Wed, 20 Jul 2016 03:39:09 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:54448 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbcGTHjG (ORCPT ); Wed, 20 Jul 2016 03:39:06 -0400 X-AuditID: cbfee68e-f79266d000001428-d0-578f2a888754 From: Chanwoo Choi To: linux-kernel@vger.kernel.org Cc: cw00.choi@samsung.com, myungjoo.ham@samsung.com, ckeepax@opensource.wolfsonmicro.com Subject: [PATCH 3/4] extcon: Remove the state_store() to prevent the wrong access Date: Wed, 20 Jul 2016 16:38:46 +0900 Message-id: <1469000327-15615-4-git-send-email-cw00.choi@samsung.com> X-Mailer: git-send-email 1.8.0 In-reply-to: <1469000327-15615-1-git-send-email-cw00.choi@samsung.com> References: <1469000327-15615-1-git-send-email-cw00.choi@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrILMWRmVeSWpSXmKPExsWyRsSkQLdDqz/coOmBssW/KTfYLa5/ec5q cXnXHDaL240r2BxYPF5O/M3m0bdlFaPH501yAcxRXDYpqTmZZalF+nYJXBnz5lkUHOSsePLw KlMD40P2LkZODgkBE4kdV05D2WISF+6tZ+ti5OIQEljBKHF922dWmKJHLyawQySWMkqcWTWN EcL5wijxsqWXEaSKTUBLYv+LG2wgtoiAgsTm3mdg3cwCURJHLn8B6ubgEBYIlti8ORQkzCKg KnHuWQcziM0r4Cqx+MZDNohlchIf9jwCu4hTwE1i0/nnYDVCQDVbNp4Hu05C4DubROOzQ6wQ gwQkvk0+xAIyX0JAVmLTAWaIOZISB1fcYJnAKLyAkWEVo2hqQXJBcVJ6kZFecWJucWleul5y fu4mRmDInv73rG8H480D1ocYBTgYlXh4Iw72hQuxJpYVV+YeYjQF2jCRWUo0OR8YGXkl8YbG ZkYWpiamxkbmlmZK4rwJUj+DhQTSE0tSs1NTC1KL4otKc1KLDzEycXBKNTDasi3Zynf729fD evt55vvaHNtz/1TD+gKLyWn7os5IGOg7abDwPfq/2M0043/UYdmmnev8tTP0v8V7rymI6pi7 vLSRd7KFzOSwBtbmyXMLLp/5/1ozd7uPYE6Ud8/tDkXPBiFPvUMmPZ6nNatbq0NnOUnVf5Jf 3NTenfx8+XnTY34ZhhU3BZVYijMSDbWYi4oTAVADnd5UAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42I5/e+xgG6HVn+4wcvd8hb/ptxgt7j+5Tmr xeVdc9gsbjeuYHNg8Xg58TebR9+WVYwenzfJBTBHNTDaZKQmpqQWKaTmJeenZOal2yp5B8c7 x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gCtU1IoS8wpBQoFJBYXK+nbYZoQGuKmawHTGKHr GxIE12NkgAYS1jBmzJtnUXCQs+LJw6tMDYwP2bsYOTkkBEwkHr2YAGWLSVy4t56ti5GLQ0hg KaPEmVXTGCGcL4wSL1t6GUGq2AS0JPa/uMEGYosIKEhs7n3GCmIzC0RJHLn8BWgSB4ewQLDE 5s2hIGEWAVWJc886mEFsXgFXicU3HrJBLJOT+LDnEdhiTgE3iU3nn4PVCAHVbNl4nm0CI+8C RoZVjBKpBckFxUnpuYZ5qeV6xYm5xaV56XrJ+bmbGMFx8UxqB+PBXe6HGAU4GJV4eCMO9oUL sSaWFVfmHmKU4GBWEuFdo9YfLsSbklhZlVqUH19UmpNafIjRFOiwicxSosn5wJjNK4k3NDYx M7I0Mje0MDI2VxLnffx/XZiQQHpiSWp2ampBahFMHxMHp1QDI3ve/Tkm7M+n+bicEYn/X1I6 lSu2uNSIP6hiI+/2G09yCg49+3Tf8eBbNfOsPV6u5gyccj9ie+Zs63/3tbDuVc/26dteMcSr 20Q+uBW2OSbon4KE/6VF/ge57Nb5XL7Jc3bGjMz/UZ2GE7VDIz80ia/cWsa1Kju2OfTvyeC+ 5zK3YqXCpQNKlFiKMxINtZiLihMBLbdNcaECAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch removes the state_store() which change the state of external connectors with bit masking on user-space. It is wrong access to modify the change the state of external connectors. Signed-off-by: Chanwoo Choi --- drivers/extcon/extcon.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 319659c6af28..ad5e4546f82c 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -174,26 +174,7 @@ static ssize_t state_show(struct device *dev, struct device_attribute *attr, return count; } - -static ssize_t state_store(struct device *dev, struct device_attribute *attr, - const char *buf, size_t count) -{ - u32 state; - ssize_t ret = 0; - struct extcon_dev *edev = dev_get_drvdata(dev); - - ret = sscanf(buf, "0x%x", &state); - if (ret == 0) - ret = -EINVAL; - else - ret = extcon_set_state(edev, state); - - if (ret < 0) - return ret; - - return count; -} -static DEVICE_ATTR_RW(state); +static DEVICE_ATTR_RO(state); static ssize_t name_show(struct device *dev, struct device_attribute *attr, char *buf) -- 1.9.1