From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752950AbcGVDq1 (ORCPT ); Thu, 21 Jul 2016 23:46:27 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:36120 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbcGVDq0 (ORCPT ); Thu, 21 Jul 2016 23:46:26 -0400 From: Zhou Chengming To: , CC: , , , , , Subject: [PATCH] update sc->nr_reclaimed after each shrink_slab Date: Fri, 22 Jul 2016 11:43:30 +0800 Message-ID: <1469159010-5636-1-git-send-email-zhouchengming1@huawei.com> X-Mailer: git-send-email 1.7.12.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090204.57919700.0035,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: aa617fa89edd14d7d7b6d2ba456652fe Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In !global_reclaim(sc) case, we should update sc->nr_reclaimed after each shrink_slab in the loop. Because we need the correct sc->nr_reclaimed value to see if we can break out. Signed-off-by: Zhou Chengming --- mm/vmscan.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index c4a2f45..47133c3 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -2405,6 +2405,11 @@ static bool shrink_zone(struct zone *zone, struct scan_control *sc, memcg, sc->nr_scanned - scanned, lru_pages); + if (!global_reclaim(sc) && reclaim_state) { + sc->nr_reclaimed += reclaim_state->reclaimed_slab; + reclaim_state->reclaimed_slab = 0; + } + /* Record the group's reclaim efficiency */ vmpressure(sc->gfp_mask, memcg, false, sc->nr_scanned - scanned, -- 1.7.7