From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753937AbcGVMj4 (ORCPT ); Fri, 22 Jul 2016 08:39:56 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:35187 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753444AbcGVMjz (ORCPT ); Fri, 22 Jul 2016 08:39:55 -0400 Message-ID: <1469191192.27223.17.camel@pengutronix.de> Subject: Re: [PATCH] reset: return -ENOTSUPP if CONFIG_RESET_CONTROLLER is undefined From: Philipp Zabel To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org, Hans de Goede , Lee Jones Date: Fri, 22 Jul 2016 14:39:52 +0200 In-Reply-To: <1469077585-23237-1-git-send-email-yamada.masahiro@socionext.com> References: <1469077585-23237-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, Am Donnerstag, den 21.07.2016, 14:06 +0900 schrieb Masahiro Yamada: > This has been inconsistent; some returns -EINVAL, some -ENOTSUPP. > Make it consistent in this header, in favor of -ENOTSUPP. > > Signed-off-by: Masahiro Yamada > --- > > include/linux/reset.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/reset.h b/include/linux/reset.h > index 5894f0f..c875b4b 100644 > --- a/include/linux/reset.h > +++ b/include/linux/reset.h > @@ -71,14 +71,14 @@ static inline struct reset_control *__of_reset_control_get( > struct device_node *node, > const char *id, int index, int shared) > { > - return ERR_PTR(-EINVAL); > + return ERR_PTR(-ENOTSUPP); > } > > static inline struct reset_control *__devm_reset_control_get( > struct device *dev, > const char *id, int index, int shared) > { > - return ERR_PTR(-EINVAL); > + return ERR_PTR(-ENOTSUPP); > } > > #endif /* CONFIG_RESET_CONTROLLER */ Thanks, this has already been changed in commit 168d7c4e8bb2 ("reset: Return -ENOTSUPP when not configured"). regards Philipp